-
-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: CSS output extra details about lang(*) dir(*) #8405
Comments
Refer to #7811. |
Seem not to solve the problem for default downgrade application css. This default behavior is unacceptable. |
Hi, you should set a proper |
This behavior is unreasonable and unacceptable. |
If lightningcss does not downgrade the CSS, it will not work in legacy browsers. If you have any suggestions on the transformation results of lightingcss, please file an issue in the lightningcss repository: https://github.com/parcel-bundler/lightningcss |
My concern stems from rspack's "default settings" here, which are unrelated to lightningcss. Rspak should establish a default configuration that prevents lightningcss from arbitrarily downgrading CSS on its own. This aligns with developers' understanding of packaging tools like webpack, without the need to delve into any messy details beyond packaging. |
I totally understand your claim. Unfortunately, lightningcss does not currently allow to do this. refer to parcel-bundler/lightningcss#792 |
System Info
System:
OS: macOS 14.4
CPU: (32) x64 13th Gen Intel(R) Core(TM) i9-13900KF
Memory: 6.79 GB / 32.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 22.8.0 - /usr/local/bin/node
npm: 10.8.2 - /usr/local/bin/npm
pnpm: 9.9.0 - /usr/local/bin/pnpm
bun: 1.1.24 - /usr/local/bin/bun
Watchman: 2024.06.10.00 - /usr/local/bin/watchman
Details
After update to rsapck version > 0.1.4 , build app then output css that has extra unnessary content:
Here is the origin css:
Tried custom LightningCssMinimizerRspackPlugin options:
Still dir selector exsit:
Temp resolution is downgrading rspack version to 1.0.4 or set targets to
chrome >= 120
:Reproduce link
No response
Reproduce Steps
see above.
The text was updated successfully, but these errors were encountered: