perf: reduce memory consumption of `CachedSource` #8666

h-a-n-a · 2024-12-11T08:11:02Z

Summary

Syncing with rspack-sources web-infra-dev/rspack-sources#144

Checklist

Tests updated (or not required).
Documentation updated (or not required).

netlify · 2024-12-11T08:11:22Z

✅ Deploy Preview for rspack ready!

Name	Link
🔨 Latest commit	`940eedf`
🔍 Latest deploy log	https://app.netlify.com/sites/rspack/deploys/675c1a1899a1740008a7e2d0
😎 Deploy Preview	https://deploy-preview-8666--rspack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

h-a-n-a · 2024-12-13T04:59:39Z

!bench

rspack-bot · 2024-12-13T05:00:01Z

📝 Benchmark detail: Open

Name	Base (2024-12-13 c81fa8d)	Current	Change
10000_big_production-mode_disable-minimize + exec	37.7 s ± 976 ms	38.1 s ± 384 ms	+1.18 %
10000_development-mode + exec	1.79 s ± 21 ms	1.78 s ± 25 ms	-0.41 %
10000_development-mode_hmr + exec	656 ms ± 7.9 ms	678 ms ± 27 ms	+3.31 %
10000_production-mode + exec	2.33 s ± 42 ms	2.36 s ± 21 ms	+1.64 %
arco-pro_development-mode + exec	1.74 s ± 73 ms	1.75 s ± 79 ms	+0.73 %
arco-pro_development-mode_hmr + exec	379 ms ± 1.3 ms	425 ms ± 2.7 ms	+12.11 %
arco-pro_production-mode + exec	3.11 s ± 87 ms	3.21 s ± 70 ms	+3.04 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.17 s ± 78 ms	3.23 s ± 99 ms	+2.17 %
arco-pro_production-mode_traverse-chunk-modules + exec	3.12 s ± 93 ms	3.2 s ± 82 ms	+2.57 %
threejs_development-mode_10x + exec	1.6 s ± 9.6 ms	1.61 s ± 27 ms	+0.70 %
threejs_development-mode_10x_hmr + exec	789 ms ± 24 ms	796 ms ± 8.4 ms	+0.86 %
threejs_production-mode_10x + exec	4.94 s ± 110 ms	5.08 s ± 40 ms	+2.78 %
10000_big_production-mode_disable-minimize + rss memory	9737 MiB ± 290 MiB	9684 MiB ± 32.5 MiB	-0.55 %
10000_development-mode + rss memory	808 MiB ± 16.8 MiB	719 MiB ± 32.1 MiB	-11.01 %
10000_development-mode_hmr + rss memory	1906 MiB ± 321 MiB	1509 MiB ± 310 MiB	-20.82 %
10000_production-mode + rss memory	699 MiB ± 38.9 MiB	686 MiB ± 42 MiB	-1.93 %
arco-pro_development-mode + rss memory	732 MiB ± 47.1 MiB	638 MiB ± 38.8 MiB	-12.93 %
arco-pro_development-mode_hmr + rss memory	825 MiB ± 19.7 MiB	822 MiB ± 81.9 MiB	-0.48 %
arco-pro_production-mode + rss memory	792 MiB ± 69.8 MiB	777 MiB ± 53.1 MiB	-1.92 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory	815 MiB ± 54.2 MiB	787 MiB ± 49.4 MiB	-3.42 %
arco-pro_production-mode_traverse-chunk-modules + rss memory	841 MiB ± 32.3 MiB	776 MiB ± 57 MiB	-7.68 %
threejs_development-mode_10x + rss memory	782 MiB ± 63.4 MiB	699 MiB ± 59 MiB	-10.57 %
threejs_development-mode_10x_hmr + rss memory	1686 MiB ± 334 MiB	1315 MiB ± 399 MiB	-21.99 %
threejs_production-mode_10x + rss memory	1103 MiB ± 83.2 MiB	1026 MiB ± 91.2 MiB	-7.00 %

Threshold exceeded: ["arco-pro_development-mode_hmr + exec"]

h-a-n-a · 2024-12-13T05:33:09Z

!bench

rspack-bot · 2024-12-13T05:33:31Z

📝 Benchmark detail: Open

Name	Base (2024-12-13 c81fa8d)	Current	Change
10000_big_production-mode_disable-minimize + exec	37.7 s ± 976 ms	38.5 s ± 326 ms	+2.28 %
10000_development-mode + exec	1.79 s ± 21 ms	1.81 s ± 15 ms	+1.01 %
10000_development-mode_hmr + exec	656 ms ± 7.9 ms	674 ms ± 9.2 ms	+2.70 %
10000_production-mode + exec	2.33 s ± 42 ms	2.37 s ± 20 ms	+1.85 %
arco-pro_development-mode + exec	1.74 s ± 73 ms	1.73 s ± 66 ms	-0.43 %
arco-pro_development-mode_hmr + exec	379 ms ± 1.3 ms	379 ms ± 1.5 ms	+0.01 %
arco-pro_production-mode + exec	3.11 s ± 87 ms	3.18 s ± 82 ms	+2.38 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.17 s ± 78 ms	3.22 s ± 57 ms	+1.62 %
arco-pro_production-mode_traverse-chunk-modules + exec	3.12 s ± 93 ms	3.22 s ± 91 ms	+3.18 %
threejs_development-mode_10x + exec	1.6 s ± 9.6 ms	1.6 s ± 14 ms	+0.01 %
threejs_development-mode_10x_hmr + exec	789 ms ± 24 ms	785 ms ± 11 ms	-0.51 %
threejs_production-mode_10x + exec	4.94 s ± 110 ms	5.07 s ± 31 ms	+2.63 %
10000_big_production-mode_disable-minimize + rss memory	9737 MiB ± 290 MiB	9750 MiB ± 229 MiB	+0.14 %
10000_development-mode + rss memory	808 MiB ± 16.8 MiB	717 MiB ± 40.5 MiB	-11.27 %
10000_development-mode_hmr + rss memory	1906 MiB ± 321 MiB	1515 MiB ± 370 MiB	-20.51 %
10000_production-mode + rss memory	699 MiB ± 38.9 MiB	678 MiB ± 28 MiB	-3.04 %
arco-pro_development-mode + rss memory	732 MiB ± 47.1 MiB	650 MiB ± 42.6 MiB	-11.25 %
arco-pro_development-mode_hmr + rss memory	825 MiB ± 19.7 MiB	671 MiB ± 129 MiB	-18.68 %
arco-pro_production-mode + rss memory	792 MiB ± 69.8 MiB	763 MiB ± 60.5 MiB	-3.71 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory	815 MiB ± 54.2 MiB	783 MiB ± 31.7 MiB	-3.95 %
arco-pro_production-mode_traverse-chunk-modules + rss memory	841 MiB ± 32.3 MiB	766 MiB ± 64.3 MiB	-8.97 %
threejs_development-mode_10x + rss memory	782 MiB ± 63.4 MiB	722 MiB ± 45.1 MiB	-7.69 %
threejs_development-mode_10x_hmr + rss memory	1686 MiB ± 334 MiB	1325 MiB ± 212 MiB	-21.38 %
threejs_production-mode_10x + rss memory	1103 MiB ± 83.2 MiB	1020 MiB ± 66.1 MiB	-7.53 %

h-a-n-a · 2024-12-13T08:28:04Z

!bench

rspack-bot · 2024-12-13T08:28:27Z

📝 Benchmark detail: Open

Name	Base (2024-12-13 c81fa8d)	Current	Change
10000_big_production-mode_disable-minimize + exec	37.7 s ± 976 ms	38.1 s ± 778 ms	+1.05 %
10000_development-mode + exec	1.79 s ± 21 ms	1.76 s ± 25 ms	-1.83 %
10000_development-mode_hmr + exec	656 ms ± 7.9 ms	673 ms ± 36 ms	+2.54 %
10000_production-mode + exec	2.33 s ± 42 ms	2.39 s ± 35 ms	+2.71 %
arco-pro_development-mode + exec	1.74 s ± 73 ms	1.73 s ± 57 ms	-0.56 %
arco-pro_development-mode_hmr + exec	379 ms ± 1.3 ms	378 ms ± 1.2 ms	-0.17 %
arco-pro_production-mode + exec	3.11 s ± 87 ms	3.22 s ± 83 ms	+3.43 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.17 s ± 78 ms	3.27 s ± 71 ms	+3.26 %
arco-pro_production-mode_traverse-chunk-modules + exec	3.12 s ± 93 ms	3.25 s ± 89 ms	+4.08 %
threejs_development-mode_10x + exec	1.6 s ± 9.6 ms	1.58 s ± 27 ms	-1.44 %
threejs_development-mode_10x_hmr + exec	789 ms ± 24 ms	780 ms ± 20 ms	-1.19 %
threejs_production-mode_10x + exec	4.94 s ± 110 ms	5.09 s ± 34 ms	+3.08 %
10000_big_production-mode_disable-minimize + rss memory	9737 MiB ± 290 MiB	9635 MiB ± 350 MiB	-1.04 %
10000_development-mode + rss memory	808 MiB ± 16.8 MiB	716 MiB ± 52.6 MiB	-11.39 %
10000_development-mode_hmr + rss memory	1906 MiB ± 321 MiB	1607 MiB ± 349 MiB	-15.69 %
10000_production-mode + rss memory	699 MiB ± 38.9 MiB	724 MiB ± 62.2 MiB	+3.54 %
arco-pro_development-mode + rss memory	732 MiB ± 47.1 MiB	642 MiB ± 48.5 MiB	-12.38 %
arco-pro_development-mode_hmr + rss memory	825 MiB ± 19.7 MiB	696 MiB ± 102 MiB	-15.65 %
arco-pro_production-mode + rss memory	792 MiB ± 69.8 MiB	769 MiB ± 52.5 MiB	-2.92 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory	815 MiB ± 54.2 MiB	784 MiB ± 41.7 MiB	-3.74 %
arco-pro_production-mode_traverse-chunk-modules + rss memory	841 MiB ± 32.3 MiB	790 MiB ± 62.1 MiB	-6.04 %
threejs_development-mode_10x + rss memory	782 MiB ± 63.4 MiB	703 MiB ± 44.6 MiB	-10.04 %
threejs_development-mode_10x_hmr + rss memory	1686 MiB ± 334 MiB	1256 MiB ± 146 MiB	-25.51 %
threejs_production-mode_10x + rss memory	1103 MiB ± 83.2 MiB	994 MiB ± 76.3 MiB	-9.92 %

github-actions bot added team The issue/pr is created by the member of Rspack. release: performance release: performance related release(mr only) labels Dec 11, 2024

This comment was marked as outdated.

Sign in to view

h-a-n-a force-pushed the cached-source branch from 2f0de35 to 3148c44 Compare December 13, 2024 05:32

h-a-n-a marked this pull request as ready for review December 13, 2024 06:36

github-actions bot assigned h-a-n-a Dec 13, 2024

h-a-n-a enabled auto-merge (squash) December 13, 2024 06:37

SyMind approved these changes Dec 13, 2024

View reviewed changes

h-a-n-a force-pushed the cached-source branch from 3148c44 to 2d1affb Compare December 13, 2024 08:27

h-a-n-a added 6 commits December 13, 2024 19:27

perf: init

741ad72

test: snapshot

5aced40

test: snapshot

05a1908

perf

b67162a

perf

ab18b93

upgrade

940eedf

h-a-n-a force-pushed the cached-source branch from 2d1affb to 940eedf Compare December 13, 2024 11:27

h-a-n-a merged commit 0861d4a into main Dec 13, 2024
32 checks passed

h-a-n-a deleted the cached-source branch December 13, 2024 11:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf: reduce memory consumption of `CachedSource` #8666

perf: reduce memory consumption of `CachedSource` #8666

h-a-n-a commented Dec 11, 2024 •

edited

Loading

netlify bot commented Dec 11, 2024 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

h-a-n-a commented Dec 13, 2024

rspack-bot commented Dec 13, 2024 •

edited

Loading

h-a-n-a commented Dec 13, 2024

rspack-bot commented Dec 13, 2024 •

edited

Loading

h-a-n-a commented Dec 13, 2024

rspack-bot commented Dec 13, 2024 •

edited

Loading

perf: reduce memory consumption of CachedSource #8666

perf: reduce memory consumption of CachedSource #8666

Conversation

h-a-n-a commented Dec 11, 2024 • edited Loading

Summary

Checklist

netlify bot commented Dec 11, 2024 • edited Loading

✅ Deploy Preview for rspack ready!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

h-a-n-a commented Dec 13, 2024

rspack-bot commented Dec 13, 2024 • edited Loading

h-a-n-a commented Dec 13, 2024

rspack-bot commented Dec 13, 2024 • edited Loading

h-a-n-a commented Dec 13, 2024

rspack-bot commented Dec 13, 2024 • edited Loading

perf: reduce memory consumption of `CachedSource` #8666

perf: reduce memory consumption of `CachedSource` #8666

h-a-n-a commented Dec 11, 2024 •

edited

Loading

netlify bot commented Dec 11, 2024 •

edited

Loading

rspack-bot commented Dec 13, 2024 •

edited

Loading

rspack-bot commented Dec 13, 2024 •

edited

Loading

rspack-bot commented Dec 13, 2024 •

edited

Loading