Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export WarnCaseSensitiveModulesPlugin and disable it by default #8697

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

ahabhgk
Copy link
Collaborator

@ahabhgk ahabhgk commented Dec 13, 2024

Summary

WarnCaseSensitiveModulesPlugin check case-sensitive modules, before we enable it by default in both dev mode and production mode, but since this is only a "linter" plugin so we disable it by default in both dev mode and production mode, we recommend users use plugins: [new rspack.WarnCaseSensitiveModulesPlugin()] to add it themselves by their own needs

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Dec 13, 2024
Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit b8919ab
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/675c19e6d8781e000804dc1c
😎 Deploy Preview https://deploy-preview-8697--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ahabhgk ahabhgk enabled auto-merge (squash) December 13, 2024 09:39
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this change benefits the build perf?

@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Dec 13, 2024

Yes

@ahabhgk ahabhgk merged commit caabc6f into main Dec 13, 2024
31 checks passed
@ahabhgk ahabhgk deleted the feat-warn-case branch December 13, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants