-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding infinity
/NaN
tests for more interop-2023-mathfunctions tests
#306
Comments
@nairnandu has checked with @lilles, this one is OK for Chromium. |
Seems fine to have more test coverage, though do we have the test list? |
Fwiw, I've also added various new general NaN/inf calc tests whilst improving Gecko's implementation downstream in the last ~month. (Usually ones I've caught whilst improving so other vendors can ensure they don't have the same issues which were otherwise untested.) No tests for the functions mentioned exist yet though. General NaN/inf tests are not covered under interior 2023 (any tag). |
I believe we're OK with this; the tests were added as part of the Gecko implementation. I don't think we can/should extend the scope to NaN/Infinity handling beyond the math functions (although of course having the tests is useful anyway). CC @emilio |
I've taken a look at https://wpt.fyi/results/css/css-values and the @CanadaHonk are there additional tests you want to add? I think the easiest way to proceed if you want to add additional tests is to send a wpt PR and refer to this issue. |
@foolip I was mostly ensuring it's fine to add tests under interop 2023 label(s) for some potential Gecko implementation improvements with inf/nan, will likely add some in the upcoming month(s) if ran into. Thanks! |
@CanadaHonk please do improve test coverage if you're able to while working on this in Gecko. If they are new tests and we'll need to label them to include in Interop 2023, would you mind filing a new issue? For now, I'll go ahead and close this. |
exp-log-*
,hypot-pow-sqrt-*
, andround-mod-rem-*
all lack any tests usinginfinity
or-infinity
orNaN
, would be nice to have those as well like the otherinterop-2023-mathfunctions
tests (imo).The text was updated successfully, but these errors were encountered: