Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding infinity/NaN tests for more interop-2023-mathfunctions tests #306

Closed
CanadaHonk opened this issue Mar 5, 2023 · 7 comments
Labels
focus area: CSS Math Functions test-change-proposal Proposal to add or remove tests for an interop area

Comments

@CanadaHonk
Copy link

exp-log-*, hypot-pow-sqrt-*, and round-mod-rem-* all lack any tests using infinity or -infinity or NaN, would be nice to have those as well like the other interop-2023-mathfunctions tests (imo).

@nt1m nt1m transferred this issue from web-platform-tests/wpt Mar 18, 2023
@nt1m nt1m added the test-change-proposal Proposal to add or remove tests for an interop area label Mar 18, 2023
@foolip
Copy link
Member

foolip commented Mar 30, 2023

@nairnandu has checked with @lilles, this one is OK for Chromium.

@nt1m
Copy link
Member

nt1m commented Mar 30, 2023

Seems fine to have more test coverage, though do we have the test list?

@CanadaHonk
Copy link
Author

CanadaHonk commented Mar 30, 2023

Fwiw, I've also added various new general NaN/inf calc tests whilst improving Gecko's implementation downstream in the last ~month. (Usually ones I've caught whilst improving so other vendors can ensure they don't have the same issues which were otherwise untested.) No tests for the functions mentioned exist yet though.

General NaN/inf tests are not covered under interior 2023 (any tag).

@jgraham
Copy link
Contributor

jgraham commented Mar 30, 2023

I believe we're OK with this; the tests were added as part of the Gecko implementation. I don't think we can/should extend the scope to NaN/Infinity handling beyond the math functions (although of course having the tests is useful anyway). CC @emilio

@foolip
Copy link
Member

foolip commented Apr 26, 2023

I've taken a look at https://wpt.fyi/results/css/css-values and the exp-log-*, hypot-pow-sqrt-*, and round-mod-rem-* tests mentioned are all already labeled.

@CanadaHonk are there additional tests you want to add? I think the easiest way to proceed if you want to add additional tests is to send a wpt PR and refer to this issue.

@CanadaHonk
Copy link
Author

@foolip I was mostly ensuring it's fine to add tests under interop 2023 label(s) for some potential Gecko implementation improvements with inf/nan, will likely add some in the upcoming month(s) if ran into. Thanks!

@foolip
Copy link
Member

foolip commented May 10, 2023

@CanadaHonk please do improve test coverage if you're able to while working on this in Gecko. If they are new tests and we'll need to label them to include in Interop 2023, would you mind filing a new issue? For now, I'll go ahead and close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus area: CSS Math Functions test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Development

No branches or pull requests

5 participants