Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting a time limit for Test Change Proposal feedback #354

Closed
foolip opened this issue Jun 8, 2023 · 3 comments
Closed

Setting a time limit for Test Change Proposal feedback #354

foolip opened this issue Jun 8, 2023 · 3 comments

Comments

@foolip
Copy link
Member

foolip commented Jun 8, 2023

We currently require explicit sign-off from a representative for each of Chromium, Gecko and WebKit to accept test change proposals.

This requires pinging people on GitHub and often we use interop team meeting time for this as well, but usually just for what amounts to a ping, rarely discussion.

Using #327 as an example, it took a month to resolve.

Since the vast majority of changes are not controversial, I would like to suggest a change to the process to not require explicit sign-off. Taking inspiration from https://github.com/web-platform-tests/rfcs, I would suggest adding this to our README:

In the case of no substantive disagreement the test change proposal is considered accepted after 1 week.

@nt1m
Copy link
Member

nt1m commented Jun 9, 2023

I disagree with this suggestion, I usually try to answer test change proposals ASAP (in fact most of them take under a week), but sometimes I prefer having an expert review the tests. In the case of #327, our Motion Path expert was out, hence the long reply time, but this is usually the exception.

@jgraham
Copy link
Contributor

jgraham commented Jun 9, 2023

Yeah I agree with @nt1m. Changing the tests that form the metric is a non-trivial action, and it's important that people don't feel like this is happening without their explicit consent.

@foolip
Copy link
Member Author

foolip commented Jun 9, 2023

In that case, is there something else we can do to resolve test change proposals faster? One month is an outlier, but my hunch is that two weeks is pretty typical.

@foolip foolip closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants