Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add currentColor color-mix tests #97

Closed
nt1m opened this issue Jul 24, 2022 · 9 comments
Closed

Add currentColor color-mix tests #97

nt1m opened this issue Jul 24, 2022 · 9 comments
Labels
test-change-proposal Proposal to add or remove tests for an interop area

Comments

@nt1m
Copy link
Member

nt1m commented Jul 24, 2022

** Test List **

  • css/css-color/color-mix-currentcolor-001.html
  • css/css-color/color-mix-currentcolor-002.html

** Rationale **

It's a very useful part of color-mix and Gecko supports this properly, while WebKit doesn't.
@nt1m nt1m added the test-change-proposal Proposal to add or remove tests for an interop area label Jul 24, 2022
@nt1m
Copy link
Member Author

nt1m commented Jul 25, 2022

cc @emilio

@foolip foolip mentioned this issue Jul 27, 2022
Closed
@jgraham
Copy link
Contributor

jgraham commented Jul 28, 2022

https://wpt.fyi/results/css/css-color?label=master&label=experimental&aligned&q=color-mix-currentcolor

This seems like a substantive change which increases the featureset covered, so we need to have clear consensus to add the tests.

@emilio
Copy link

emilio commented Jul 28, 2022

I don't think it does if all the other color-mix() test-cases are included, does it?

@emilio
Copy link

emilio commented Jul 28, 2022

(In any case, +1 to add these)

@bramus
Copy link

bramus commented Jul 28, 2022

@lilles: PTAL

@foolip
Copy link
Member

foolip commented Aug 18, 2022

@sesse WDYT?

@sesse
Copy link

sesse commented Aug 18, 2022

No objections from me.

@foolip
Copy link
Member

foolip commented Aug 18, 2022

Thanks @sesse! With support from representatives of Chromium, Gecko, and WebKit, I'll go ahead and label these two tests now.

@foolip
Copy link
Member

foolip commented Aug 18, 2022

Done in web-platform-tests/wpt-metadata#2962.

@foolip foolip closed this as completed Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@bramus @sesse @jgraham @foolip @emilio @nt1m