Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRs that update the Docker image should run tests on that image #3187

Closed
past opened this issue Mar 7, 2023 · 0 comments · Fixed by #4098
Closed

PRs that update the Docker image should run tests on that image #3187

past opened this issue Mar 7, 2023 · 0 comments · Fixed by #4098

Comments

@past
Copy link
Member

past commented Mar 7, 2023

Kyle tells me that we used to have this in Travis CI, but we might have left it behind after the migration to GitHub actions.

Right now PRs that modify any of the docker configuration files (e.g. #3180) fail in CI because the GitHub actions use the latest docker image from merges to the main branch. A sketch of the desired solution here would be to change .github/actions/make-in-docker/action.yml to:

image: docker://webplatformtests/wpt.fyi:${{ vars.GITHUB_REF_NAME }}

And perhaps also set tag_names: true in docker-update.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant