Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interop view empty? #514

Closed
gsnedders opened this issue Sep 3, 2018 · 3 comments
Closed

Interop view empty? #514

gsnedders opened this issue Sep 3, 2018 · 3 comments
Assignees
Labels
bug Something isn't working regression Something isn't working, but used to

Comments

@gsnedders
Copy link
Member

Currently, going to https://wpt.fyi and clicking on "Interoperability" shows an empty page, with no browsers and no paths loaded.

[Error] Failed to load resource: the server responded with a status of 404 () (https://wpt.fyi/api/interop?complete=true, line 0)
[Error] Unhandled Promise Rejection: Failed to fetch interop data
	(anonymous function) (data:text/javascript;charset=utf-8,%0A…%0A:70)
	asyncFunctionResume
	(anonymous function)
	promiseReactionJob
@gsnedders gsnedders added bug Something isn't working regression Something isn't working, but used to labels Sep 3, 2018
@mdittmer mdittmer self-assigned this Sep 4, 2018
@lukebjerring
Copy link
Contributor

The reason for this issue is that the CRON job that computes the interop data is running daily, but occassionally (most of the time) we have complete runs land sometime throughout the day, without the interop being re-computed.

Ideally, we need to:

  • change to a push-based model
  • run the interop more frequently / on update
  • have the UI fall back to the most recent instead of 404'ing

In the meantime, whenever the complete run is ahead of interop, it can be quick-fixed by (manually) re-running the Travis CRON job for labels="" @ https://travis-ci.org/web-platform-tests/results-analysis

@Hexcles and I have discussed that push-events can be done from the results-receiver (when a new run is created). We'll need an "subscriber" endpoint for executing a check as to interop scores being up-to-date or not.

@mdittmer
Copy link
Contributor

mdittmer commented Sep 4, 2018

EDIT: Sorry for the double-post. Had a stale tab open.

This occurs because interop computations are only run daily, but the client code assumes that the latest runs that match query params must have interop data (which is often not the case). @lukebjerring and I have discussed a few long- and short-term fixes to this.

The most immediate fix is to move those cron jobs to run hourly so that the data are correct more often than they are now.

@lukebjerring
Copy link
Contributor

lukebjerring commented Sep 26, 2018

Fixed via prod push #561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Something isn't working, but used to
Projects
None yet
Development

No branches or pull requests

3 participants