Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch in service-port declaration between terraform and WPT config #33

Open
stephenmcgruer opened this issue Jul 10, 2020 · 0 comments

Comments

@stephenmcgruer
Copy link
Contributor

src/wpt-config.json.template has:

  "ports": {
    "http": [80, 8000],
    "https": [443, 8443],
    "ws": [8001],
    "wss": [8002],
    "http2": [8003]
  },

Whilst infrastructure/web-platform-tests/main.tf has:

  service_port_1      = 80
  service_port_1_name = "http-primary"
  service_port_2      = 8000
  service_port_2_name = "http-secondary"
  service_port_3      = 443
  service_port_3_name = "https"
  service_port_4      = 8001
  service_port_4_name = "http2"
  service_port_5      = 8002
  service_port_5_name = "websocket"
  service_port_6      = 8003
  service_port_6_name = "websocket-secure"

I don't think this has any semantic impact since the terraform config is just exposing the ports, but technically per wptserve 8001 should be "websocket", 8002 should be "websocket-secure", and 8003 should be "http2".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant