Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make --headless the default for Chrome #13195

Closed
foolip opened this issue Sep 24, 2018 · 2 comments · Fixed by #44515
Closed

Make --headless the default for Chrome #13195

foolip opened this issue Sep 24, 2018 · 2 comments · Fixed by #44515
Labels
infra priority:backlog

Comments

@foolip
Copy link
Member

foolip commented Sep 24, 2018

Support for --headless and --no-headless was added in #13005 / #13076. It's enabled by default for Firefox but not for Chrome.

For Chrome, some tests are failing with --headless. Fix those and flip the default.
@foolip
Copy link
Member Author

foolip commented Sep 24, 2018

@jgraham do you recall which the failing tests were? Some in infrastructure/ perhaps?

@jgraham
Copy link
Contributor

jgraham commented Sep 25, 2018 

./wpt run --install-fonts --metadata infrastructure/metadata/ --log-tbpl=tbpl.log chrome infrastructure/

web-platform-test
~~~~~~~~~~~~~~~~~
Ran 137 checks (46 tests, 91 subtests)
Expected results: 135
Skipped: 2 tests
OK
 1:37.99 INFO Closing logging queue
 1:37.99 INFO queue closed

./wpt run --headless --install-fonts --metadata infrastructure/metadata/ --log-tbpl=tbpl.log chrome infrastructure/

[…]

Unexpected Results
------------------
/infrastructure/assumptions/ahem.html
  FAIL /infrastructure/assumptions/ahem.html - /infrastructure/assumptions/ahem.html 1454a0ff3cf9136b81887525b2d5d79bfe299e80
/infrastructure/assumptions/ahem-ref.html 96ad8d6e22c85614f2bbade4d1732f628a98bc1d
Testing 1454a0ff3cf9136b81887525b2d5d79bfe299e80 == 96ad8d6e22c85614f2bbade4d1732f628a98bc1d
/infrastructure/reftest/reftest.https.html
  FAIL /infrastructure/reftest/reftest.https.html - /infrastructure/reftest/reftest.https.html 431b3dc7dbfb26ba548c39598135074daded1bb7
/infrastructure/reftest/green.html 3d4f198a06ccb2ed8cf21ed8029d3a9d230d02be
Testing 431b3dc7dbfb26ba548c39598135074daded1bb7 == 3d4f198a06ccb2ed8cf21ed8029d3a9d230d02be
/infrastructure/server/context.any.serviceworker.html
  TIMEOUT /infrastructure/server/context.any.serviceworker.html
/infrastructure/server/secure-context.https.any.html
  TIMEOUT /infrastructure/server/secure-context.https.any.html
/infrastructure/server/secure-context.https.any.serviceworker.html
  TIMEOUT /infrastructure/server/secure-context.https.any.serviceworker.html
/infrastructure/server/secure-context.https.any.sharedworker.html
  TIMEOUT /infrastructure/server/secure-context.https.any.sharedworker.html
/infrastructure/server/secure-context.https.any.worker.html
  TIMEOUT /infrastructure/server/secure-context.https.any.worker.html
/infrastructure/server/wpt-server-http.sub.html
  FAIL HTTPS protocol, no subdomain - assert_true: expected true got false
    at Test.<anonymous> (http://web-platform.test:8000/infrastructure/server/wpt-server-http.sub.html:141:5)
    at Test.step (http://web-platform.test:8000/resources/testharness.js:1561:25)
    at http://web-platform.test:8000/resources/testharness.js:1585:35
    at HTMLImageElement.img.onerror (http://web-platform.test:8000/infrastructure/server/wpt-server-http.sub.html:18:5)
  FAIL HTTPS protocol, www subdomain #1 - assert_true: expected true got false
    at Test.<anonymous> (http://web-platform.test:8000/infrastructure/server/wpt-server-http.sub.html:149:5)
    at Test.step (http://web-platform.test:8000/resources/testharness.js:1561:25)
    at http://web-platform.test:8000/resources/testharness.js:1585:35
    at HTMLImageElement.img.onerror (http://web-platform.test:8000/infrastructure/server/wpt-server-http.sub.html:18:5)
  FAIL HTTPS protocol, www subdomain #2 - assert_true: expected true got false
    at Test.<anonymous> (http://web-platform.test:8000/infrastructure/server/wpt-server-http.sub.html:157:5)
    at Test.step (http://web-platform.test:8000/resources/testharness.js:1561:25)
    at http://web-platform.test:8000/resources/testharness.js:1585:35
    at HTMLImageElement.img.onerror (http://web-platform.test:8000/infrastructure/server/wpt-server-http.sub.html:18:5)
  FAIL HTTPS protocol, www subdomain #3 - assert_true: expected true got false
    at Test.<anonymous> (http://web-platform.test:8000/infrastructure/server/wpt-server-http.sub.html:165:5)
    at Test.step (http://web-platform.test:8000/resources/testharness.js:1561:25)
    at http://web-platform.test:8000/resources/testharness.js:1585:35
    at HTMLImageElement.img.onerror (http://web-platform.test:8000/infrastructure/server/wpt-server-http.sub.html:18:5)
  FAIL HTTPS protocol, punycode subdomain #1 - assert_true: expected true got false
    at Test.<anonymous> (http://web-platform.test:8000/infrastructure/server/wpt-server-http.sub.html:173:5)
    at Test.step (http://web-platform.test:8000/resources/testharness.js:1561:25)
    at http://web-platform.test:8000/resources/testharness.js:1585:35
    at HTMLImageElement.img.onerror (http://web-platform.test:8000/infrastructure/server/wpt-server-http.sub.html:18:5)
  FAIL HTTPS protocol, punycode subdomain #2 - assert_true: expected true got false
    at Test.<anonymous> (http://web-platform.test:8000/infrastructure/server/wpt-server-http.sub.html:181:5)
    at Test.step (http://web-platform.test:8000/resources/testharness.js:1561:25)
    at http://web-platform.test:8000/resources/testharness.js:1585:35
    at HTMLImageElement.img.onerror (http://web-platform.test:8000/infrastructure/server/wpt-server-http.sub.html:18:5)
/infrastructure/server/wpt-server-websocket.sub.html
  FAIL WSS protocol, no subdomain - assert_true: expected true got false
    at Test.<anonymous> (http://web-platform.test:8000/infrastructure/server/wpt-server-websocket.sub.html:75:5)
    at Test.step (http://web-platform.test:8000/resources/testharness.js:1561:25)
    at http://web-platform.test:8000/resources/testharness.js:1585:35
    at WebSocket.<anonymous> (http://web-platform.test:8000/infrastructure/server/wpt-server-websocket.sub.html:17:5)
  FAIL WSS protocol, www subdomain #1 - assert_true: expected true got false
    at Test.<anonymous> (http://web-platform.test:8000/infrastructure/server/wpt-server-websocket.sub.html:83:5)
    at Test.step (http://web-platform.test:8000/resources/testharness.js:1561:25)
    at http://web-platform.test:8000/resources/testharness.js:1585:35
    at WebSocket.<anonymous> (http://web-platform.test:8000/infrastructure/server/wpt-server-websocket.sub.html:17:5)
  FAIL WSS protocol, www subdomain #2 - assert_true: expected true got false
    at Test.<anonymous> (http://web-platform.test:8000/infrastructure/server/wpt-server-websocket.sub.html:91:5)
    at Test.step (http://web-platform.test:8000/resources/testharness.js:1561:25)
    at http://web-platform.test:8000/resources/testharness.js:1585:35
    at WebSocket.<anonymous> (http://web-platform.test:8000/infrastructure/server/wpt-server-websocket.sub.html:17:5)
  FAIL WSS protocol, www subdomain #3 - assert_true: expected true got false
    at Test.<anonymous> (http://web-platform.test:8000/infrastructure/server/wpt-server-websocket.sub.html:99:5)
    at Test.step (http://web-platform.test:8000/resources/testharness.js:1561:25)
    at http://web-platform.test:8000/resources/testharness.js:1585:35
    at WebSocket.<anonymous> (http://web-platform.test:8000/infrastructure/server/wpt-server-websocket.sub.html:17:5)
  FAIL WSS protocol, punycode subdomain #1 - assert_true: expected true got false
    at Test.<anonymous> (http://web-platform.test:8000/infrastructure/server/wpt-server-websocket.sub.html:107:5)
    at Test.step (http://web-platform.test:8000/resources/testharness.js:1561:25)
    at http://web-platform.test:8000/resources/testharness.js:1585:35
    at WebSocket.<anonymous> (http://web-platform.test:8000/infrastructure/server/wpt-server-websocket.sub.html:17:5)
  FAIL WSS protocol, punycode subdomain #2 - assert_true: expected true got false
    at Test.<anonymous> (http://web-platform.test:8000/infrastructure/server/wpt-server-websocket.sub.html:115:5)
    at Test.step (http://web-platform.test:8000/resources/testharness.js:1561:25)
    at http://web-platform.test:8000/resources/testharness.js:1585:35
    at WebSocket.<anonymous> (http://web-platform.test:8000/infrastructure/server/wpt-server-websocket.sub.html:17:5)

@past past mentioned this issue Feb 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infra priority:backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make --headless the default for Chrome and Chromium web-platform-tests/wpt
2 participants
@jgraham @foolip