Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipboard API tests rely on permissions that don't exist #36762

Open
gsnedders opened this issue Nov 1, 2022 · 2 comments
Open

Clipboard API tests rely on permissions that don't exist #36762

gsnedders opened this issue Nov 1, 2022 · 2 comments

Comments

@gsnedders
Copy link
Member

Via web-platform-tests/interop#143 (comment) (cc @whsieh):

Currently a lot of the Clipboard API tests rely on the clipboard-read and clipboard-write permissions. These were removed in w3c/clipboard-apis#132 and pending-removal in w3c/clipboard-apis#164.

Tests using `test_driver.set_permission`:
clipboard-apis/async-custom-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-custom-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/async-custom-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-custom-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/async-custom-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-custom-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/async-custom-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-custom-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/async-custom-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-custom-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/async-custom-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-custom-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/async-custom-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-custom-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/async-custom-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-custom-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/async-custom-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-custom-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/async-custom-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-custom-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/async-custom-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-custom-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/async-html-script-removal.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-html-script-removal.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/async-navigator-clipboard-read-resource-load.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-navigator-clipboard-read-sanitize.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-promise-write-blobs-read-blobs.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-promise-write-blobs-read-blobs.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/async-svg-script-removal.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-svg-script-removal.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/async-unsanitized-html-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-unsanitized-html-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/async-unsanitized-plaintext-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-unsanitized-plaintext-formats-write-read.tentative.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/async-write-blobs-read-blobs.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-write-blobs-read-blobs.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/async-write-html-read-html.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-write-html-read-html.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/async-write-image-read-image.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-write-image-read-image.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/async-write-image-read-image.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-write-image-read-image.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/async-write-svg-read-svg.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/async-write-svg-read-svg.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/detached-iframe/read-on-detaching-iframe.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/detached-iframe/read-on-detaching-iframe.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/detached-iframe/write-on-detaching-iframe.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/detached-iframe/write-on-detaching-iframe.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/detached-iframe/write-read-on-detached-iframe.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/detached-iframe/write-read-on-detached-iframe.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/detached-iframe/writeText-readText-on-detached-iframe.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/detached-iframe/writeText-readText-on-detached-iframe.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/feature-policy/clipboard-read/clipboard-read-disabled-by-feature-policy.tentative.https.sub.html:  await test_driver.set_permission({ name: 'clipboard-read' }, 'granted');
clipboard-apis/feature-policy/clipboard-read/clipboard-read-enabled-by-feature-policy.tentative.https.sub.html:  await test_driver.set_permission({ name: 'clipboard-read' }, 'granted');
clipboard-apis/feature-policy/clipboard-read/clipboard-read-enabled-on-self-origin-by-feature-policy.tentative.https.sub.html:  await test_driver.set_permission({ name: 'clipboard-read' }, 'granted');
clipboard-apis/feature-policy/clipboard-write/clipboard-write-disabled-by-feature-policy.tentative.https.sub.html:  await test_driver.set_permission({ name: 'clipboard-write' }, 'granted');
clipboard-apis/feature-policy/clipboard-write/clipboard-write-enabled-by-feature-policy.tentative.https.sub.html:  await test_driver.set_permission({ name: 'clipboard-write' }, 'granted');
clipboard-apis/feature-policy/clipboard-write/clipboard-write-enabled-on-self-origin-by-feature-policy.tentative.https.sub.html:  await test_driver.set_permission({ name: 'clipboard-write' }, 'granted');
clipboard-apis/permissions/readText-denied.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'denied');
clipboard-apis/permissions/readText-granted.https.html:  await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/permissions/writeText-denied.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'denied');
clipboard-apis/permissions/writeText-granted.https.html:  await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/text-write-read/async-write-read.https.html:    await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/text-write-read/async-write-read.https.html:    await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/text-write-read/async-write-readText.https.html:    await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/text-write-read/async-write-readText.https.html:    await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/text-write-read/async-writeText-read.https.html:    await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/text-write-read/async-writeText-read.https.html:    await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
clipboard-apis/text-write-read/async-writeText-readText.https.html:    await test_driver.set_permission({name: 'clipboard-read'}, 'granted');
clipboard-apis/text-write-read/async-writeText-readText.https.html:    await test_driver.set_permission({name: 'clipboard-write'}, 'granted');
@zcorpan
Copy link
Member

zcorpan commented Mar 2, 2023

This is a duplicate of #35600 , right?

I see two PRs, #35642 and #37098

It seems like we want a combination of those PRs? Does async-navigator-clipboard-basics.https.html need bless()?

cc @EdgarChen @marcoscaceres @snianu

@EdgarChen
Copy link
Member

#35600 is no longer valid after e120238, I think it can be closed.
This issue is more like to remove the usage of clipboard-read permission entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants