Skip to content

Commit

Permalink
fix: dfs block get ordering
Browse files Browse the repository at this point in the history
This updates dagula with a fix that changes block retrieval ordering. Previously dagula was attempting to get all block links in parallel, even though it _yielded_ blocks in DFS order. The effect was that depth traversal block "gets" were blocked by breadth "gets" i.e. all the breadth "gets" had to complete before the block get for a depth first link could complete.

It meant that dagula was using a lot more memory than needed and would "hang" for long periods fetching blocks it did not need yet. This was only experienced when fetching large DAGs.
  • Loading branch information
Alan Shaw committed Aug 14, 2023
1 parent 2c970fd commit c970c2a
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
18 changes: 9 additions & 9 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@
"@ipld/dag-json": "^10.0.1",
"@ipld/dag-pb": "^4.0.2",
"@web3-storage/content-claims": "^3.0.1",
"@web3-storage/gateway-lib": "^3.4.0",
"@web3-storage/gateway-lib": "^3.4.1",
"cardex": "^2.3.1",
"chardet": "^1.5.0",
"dagula": "^7.1.0",
"dagula": "^7.1.1",
"http-range-parse": "^1.0.0",
"lnmap": "^1.0.1",
"magic-bytes.js": "^1.0.12",
Expand Down

0 comments on commit c970c2a

Please sign in to comment.