fix: allow hash character in directory listings #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
commented
Mar 15, 2023
| @@ -11,7 +11,7 @@ import { Builder } from '../test/helpers.js' | |||
|
|
|||
| const bucketNames = ['CARPARK', 'SATNAV', 'DUDEWHERE'] | |||
| const buckets = bucketNames.map(b => new R2Bucket(new FileStorage(`./.mf/r2/${b}`))) | |||
| const builder = new Builder(...buckets) | |||
| const builder = new Builder(buckets[0], buckets[1], buckets[2]) | |||
There was a problem hiding this comment.
Changed to stop typescript complaining...
| const block = { cid: blockHeader.cid, bytes } | ||
| const block = { | ||
| cid: blockHeader.cid, | ||
| // FML, this took _so_ long to figure out: |
There was a problem hiding this comment.
oh man! glad you ended up finding it out
vasco-santos
approved these changes
Mar 15, 2023
alanshaw
pushed a commit
that referenced
this pull request
Mar 16, 2023
🤖 I have created a release *beep* *boop* --- ## [1.6.1](v1.6.0...v1.6.1) (2023-03-16) ### Bug Fixes * allow hash character in directory listings ([#27](#27)) ([64a678f](64a678f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in the new
gateway-libwith the fix for allowing hash character in directory listings.Also updates all dependencies, which includes a change in dagula to switch from our unixfs exporter fork back to
ipfs-unixfs-exporter(since the parallel block fetching from the fork was backported).ipfs-unixfs-exporternow uses.subarray()everywhere (no buffer copies) which is rad, but it also caused our tests to fail which was tricky to track down the cause. I've commented heavily in the place where the fix is.