feat: add IndexedDB Store implementation #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
a628892
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bcc367ed.ucan-protocol.pages.dev |
| Branch Preview URL: | https://feat-indexeddb-store.ucan-protocol.pages.dev |
added 2 commits
October 25, 2022 19:02
Gozala
reviewed
Oct 26, 2022
| * @param {number} [dbVersion] | ||
| */ | ||
| constructor(dbName, dbVersion) { | ||
| this.#dbName = dbName |
There was a problem hiding this comment.
Are these widely enough available for us to use ? If I recall correctly they were considered in js-multiformats but then dropped because adoption was not there yet.
There was a problem hiding this comment.
I can put underscores...
| /** @type {import('p-defer').DeferredPromise<boolean>} */ | ||
| const { resolve, reject, promise } = defer() | ||
|
|
||
| const getReq = store.get(DATA_ID) |
There was a problem hiding this comment.
Nit: I find it handy to have this function around when working with IDB
/**
* @template T
* @param {IDBRequest<T>} request
* @returns {Promise<T>}
*/
const request = (request) => new Promise((succeed, fail) => {
request.onsuccess = () => succeed(request.result)
request.onerror = () => fail(request.error)
})With which you could simply change above line as follows
Suggested change
| const getReq = store.get(DATA_ID) | |
| const result = await request(store.get(DATA_ID)) |
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
An IndexedDB store implementation that uses RSA keys for the browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An IndexedDB store implementation that uses RSA keys for the browser.