fix: validate agent name #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
commented
Dec 8, 2022
| /** @type {import('./types').SpaceMeta} */ | ||
| const meta = { isRegistered: false } | ||
| // eslint-disable-next-line eqeqeq | ||
| if (name != undefined) { |
There was a problem hiding this comment.
prettier has changed this from null to undefined but I think it has the same effect.
|
Going to merge... |
alanshaw
pushed a commit
that referenced
this pull request
Dec 8, 2022
🤖 I have created a release *beep* *boop* --- ## [9.0.1](access-v9.0.0...access-v9.0.1) (2022-12-08) ### Bug Fixes * validate agent name ([#271](#271)) ([cdccbd3](cdccbd3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
alanshaw
pushed a commit
that referenced
this pull request
Dec 8, 2022
Cannot put `undefined` in UCANs
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
Cannot put `undefined` in UCANs
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [9.0.1](access-v9.0.0...access-v9.0.1) (2022-12-08) ### Bug Fixes * validate agent name ([#271](#271)) ([5a1fdb2](5a1fdb2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
Cannot put `undefined` in UCANs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cannot put
undefinedin UCANs