feat: add w3up-client at /packages/w3up-client #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: add install & usage info to README
fix missing `:` in createClient example
Add ts types to client.
Add linting
gobengo
commented
Mar 27, 2023
| @@ -28,6 +28,7 @@ | |||
| "@web3-storage/access": "workspace:^", | |||
| "@web3-storage/capabilities": "workspace:^", | |||
| "@web3-storage/worker-utils": "0.4.3-dev", | |||
| "dotenv": "^16.0.3", | |||
There was a problem hiding this comment.
dotenv is required by the build script, so moving this from devDep to dep fixed gh workflows
3 tasks
alanshaw
approved these changes
Mar 28, 2023
This was referenced Mar 28, 2023
gobengo
pushed a commit
that referenced
this pull request
Mar 28, 2023
🤖 I have created a release *beep* *boop* --- ## [5.2.0](w3up-client-v5.1.0...w3up-client-v5.2.0) (2023-03-28) ### Features * add w3up-client at /packages/w3up-client ([#653](#653)) ([ca921ec](ca921ec)) ### Miscellaneous Chores * **access-client:** release 11.0.0-rc.0 ([#573](#573)) ([be4386d](be4386d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
1 task
|
This was referenced Mar 28, 2023
alanshaw
added a commit
that referenced
this pull request
Mar 29, 2023
🤖 I have created a release *beep* *boop* --- ## [8.2.0](upload-client-v8.1.0...upload-client-v8.2.0) (2023-03-29) ### Features * add w3up-client at /packages/w3up-client ([#653](#653)) ([ca921ec](ca921ec)) ### Bug Fixes * catch p-queue error on abort ([329de15](329de15)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
gobengo
added a commit
that referenced
this pull request
Apr 11, 2023
Motivation: * #648 * e.g. so we can iterate on w3up-client and its dependencies like `@web3-storage/access/agent` at the same time within the workspace (and modifying tests/types) without having to release anything. We can only do releases once we are sure that everything in the monorepo (now incl w3up-client) works together to accomplish a useful goal * round 2, this time not using `git subtree add` #649 (comment) How * [x] this git technique: https://stackoverflow.com/a/20974621 (via [this tip](https://github.com/web3-storage/w3protocol /pull/649#pullrequestreview-1358869478)) * [x] add `@web3-storage/w3up-client` to release-please-config * [x] add latest npm release for w3up-client to this monorepo's [release-please-config following release-please 'initial version' docs](https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md#initial-version) * [x] w3protocol monorepo github workflows call appropriate w3up-client workflows * [x] on push/pr, do w3up-client build and test f9b8e65#diff-eefdf870850494ad962a679c802b7733805b6996d8f1c6a992ae8760a366f82eR16 * [x] on commit to main branch do release-please-action to prepare a release-please pr for w3up-client publishing to npm * @gobengo: I believe this will happen via unified [`/.github/workflow/release.yml`](https://github.com/web3-storage/w3protocol/blob/main/.github/workflows/release.yml#L15) workflow, since I added w3up-client to release-please-config and manifest * [x] when w3up-client release-please pr is merged, release `@web3-storage/w3up-client` to https://www.npmjs.com/package/@web3-storage/w3up-client * should happen [via release.yml](2f8ae22#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R39) * [x] [add w3up-client to monorepo root docs build](2f8ae22#diff-b55cdbef4907b7045f32cc5360d48d262cca5f94062e353089f189f4460039e0R42) * [x] ensure w3up-client has intra-monorepo dependencies set up [using `workspace:` protocol](https://pnpm.io/workspaces#workspace-protocol-workspace) and similar use of tsconfig.json [project references](8b87fcc#diff-78dc2f52fc9c2ed3593f53799153a338a7f20eb6f16309a1175fbfcbae270118R49) * [x] w3up-client tsconfig extends monorepo root Unblocks: * add "./test" to tsconfig.json in w3up-client to type check the tests like the rest of packages in this monorepo * based on https://github.com/web3-storage/w3up-client/issues/96 --------- Co-authored-by: ice.breaker <ice.breaker@trigram.co> Co-authored-by: Yusef Napora <yusef@napora.org> Co-authored-by: ice.breaker <94936890+ice-breaker-tg@users.noreply.github.com> Co-authored-by: Jesse Harlin <harlinjesse@gmail.com> Co-authored-by: Daniel <daniel.ashcraft@ofashandfire.com> Co-authored-by: Vasco Santos <santos.vasco10@gmail.com> Co-authored-by: Hugo Dias <hugomrdias@gmail.com> Co-authored-by: Irakli Gozalishvili <contact@gozala.io> Co-authored-by: David Choi <dchoi27@gmail.com> Co-authored-by: Alan Shaw <alan.shaw@protocol.ai> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Yusef Napora <yusef@protocol.ai> Co-authored-by: Travis Vachon <travis.vachon@gmail.com> Co-authored-by: omahs <73983677+omahs@users.noreply.github.com>
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [5.2.0](w3up-client-v5.1.0...w3up-client-v5.2.0) (2023-03-28) ### Features * add w3up-client at /packages/w3up-client ([#653](#653)) ([7129181](7129181)) ### Miscellaneous Chores * **access-client:** release 11.0.0-rc.0 ([#573](#573)) ([29daa02](29daa02)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [8.2.0](upload-client-v8.1.0...upload-client-v8.2.0) (2023-03-29) ### Features * add w3up-client at /packages/w3up-client ([#653](#653)) ([7129181](7129181)) ### Bug Fixes * catch p-queue error on abort ([e4b2ce8](e4b2ce8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
@web3-storage/w3up-clientpackage to this monorepo #648@web3-storage/access/agentat the same time within the workspace (and modifying tests/types) without having to release anything. We can only do releases once we are sure that everything in the monorepo (now incl w3up-client) works together to accomplish a useful goalgit subtree addfeat: add w3up-client at /packages/w3up-client #649 (comment)How
feat: add w3up-client at /packages/w3up-client #649#pullrequestreview-1358869478))
@web3-storage/w3up-clientto release-please-config/.github/workflow/release.ymlworkflow, since I added w3up-client to release-please-config and manifest@web3-storage/w3up-clientto https://www.npmjs.com/package/@web3-storage/w3up-clientworkspace:protocol and similar use of tsconfig.json project referencesUnblocks: