fix: get solid examples working again #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vite is more particular about type imports and peer vs dev vs regular dependencies - these fixes all help make the solid examples work properly
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cfcbca2:
|
alanshaw
approved these changes
Jan 4, 2023
This was referenced Jan 4, 2023
This was referenced Jan 12, 2023
This was referenced Jan 19, 2023
This was referenced Jan 27, 2023
This was referenced Feb 1, 2023
travis
added a commit
that referenced
this pull request
Feb 8, 2023
🤖 I have created a release *beep* *boop* --- ## [2.1.0](solid-keyring-v2.0.1...solid-keyring-v2.1.0) (2023-02-06) ### Features * delegate access to spaces ([#293](#293)) ([441d757](441d757)) * import a space into w3console ([#309](#309)) ([a69a95b](a69a95b)) ### Bug Fixes * get solid examples working again ([#199](#199)) ([78ad7e9](78ad7e9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <travis@dag.house>
travis
added a commit
that referenced
this pull request
Feb 8, 2023
🤖 I have created a release *beep* *boop* --- ## [3.0.2](solid-uploader-v3.0.1...solid-uploader-v3.0.2) (2023-02-06) ### Bug Fixes * get solid examples working again ([#199](#199)) ([78ad7e9](78ad7e9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <travis@dag.house>
travis
added a commit
that referenced
this pull request
Feb 8, 2023
🤖 I have created a release *beep* *boop* --- ## [2.0.2](solid-uploads-list-v2.0.1...solid-uploads-list-v2.0.2) (2023-02-06) ### Bug Fixes * get solid examples working again ([#199](#199)) ([78ad7e9](78ad7e9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <travis@dag.house>
This was referenced Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vite is more particular about type imports and peer vs dev vs regular dependencies - these fixes all help make the solid examples work properly
frustratingly, something still seems off about the way vite is trying to load the umd build - these changes work on my pnpm branch but still fail here. code examples should be helpful for folks trying to build, but it may still be tricky to get these examples working until we move to pnpm