Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: delegate access to spaces #293

Merged
merged 7 commits into from
Jan 27, 2023
Merged

feat: delegate access to spaces #293

merged 7 commits into from
Jan 27, 2023

Conversation

olizilla
Copy link
Contributor

@olizilla olizilla commented Jan 25, 2023 •
edited
Loading

Allow user to delegate access to a space.

Adds createDelegation to keyring-core and chases it through {react,solid}-keyring

w3console-delegation.mov

To keep this PR reviewable, importing delegations will be added in a subsequent PR.

License: MIT
Signed-off-by: Oli Evans oli@protocol.ai

@olizilla
feat: import and delegate access to spaces
029000a 
allow user to delegate access to a space or import a new space

License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
@olizilla olizilla added this to the w3up phase 2 milestone Jan 26, 2023
@olizilla olizilla self-assigned this Jan 26, 2023
@olizilla olizilla mentioned this pull request Jan 26, 2023
Open
@olizilla
chore: move createDelegation to keyring-core
8962eee 
and chase it through react-keyring and solid-keyring

License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 26, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 04c7f6f:

Sandbox Source
@w3ui/example-react-file-upload Configuration
@w3ui/example-react-sign-up-in Configuration
@w3ui/example-react-uploads-list Configuration
@w3ui/example-solid-file-upload Configuration
@w3ui/example-solid-sign-up-in Configuration
@w3ui/example-solid-uploads-list Configuration
@w3ui/example-vue-file-upload Configuration
@w3ui/example-vue-sign-up-in Configuration
@w3ui/example-vue-uploads-list Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2023 •
edited
Loading

Website preview 🔗✨

@olizilla
chore: lint
01c1bf1 
License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
@olizilla olizilla marked this pull request as ready for review January 26, 2023 16:04
@olizilla
chore: lint more
8a20830 
License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
travis
travis reviewed Jan 26, 2023
View reviewed changes
Copy link
Member

@travis travis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SO COOL - couple minor comments but nothing major, :shipit:

examples/react/w3console/src/share.tsx
try {
audience = DID.parse(input.trim())
} catch (err) {
setDownloadUrl('')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to stash this error somewhere so we can tell the user why the DID they pasted is wrong or is there some other mechanism for that? either way not urgent, but probably useful for quality of life at some point

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll circle back in another PR and improve this!

examples/react/w3console/src/share.tsx Outdated
}

function onSubmit (e: React.FormEvent<HTMLFormElement>): void {
console.log('on submit', value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stray console.log I think

@olizilla
chore: remove console.log
176a994 
License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
@olizilla
fix: correct IANA media type for car
7f47f54 
License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
@olizilla
Merge branch 'main' into share-space
04c7f6f
@olizilla olizilla merged commit 441d757 into main Jan 27, 2023
@olizilla olizilla deleted the share-space branch January 27, 2023 11:09
This was referenced Jan 27, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Feb 2, 2023
Closed
Merged
Closed
Closed
travis added a commit that referenced this pull request Feb 2, 2023
@github-actions @travis
chore(main): release keyring-core 2.1.0 (#342)
0c661c6 
🤖 I have created a release *beep* *boop*
---


##
[2.1.0](keyring-core-v2.0.1...keyring-core-v2.1.0)
(2023-02-02)


### Features

* adds space-finder autocomplete combobox
([#268](#268))
([3dcd647](3dcd647))
* delegate access to spaces
([#293](#293))
([441d757](441d757))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis@dag.house>
This was referenced Feb 2, 2023
Closed
Closed
Closed
Closed
Merged
Merged
travis added a commit that referenced this pull request Feb 3, 2023
@github-actions @travis
chore(main): release keyring-core 2.1.1 (#376)
33391f9 
🤖 I have created a release *beep* *boop*
---


##
[2.1.1](keyring-core-v2.1.0...keyring-core-v2.1.1)
(2023-02-03)


### Features

* add `sameAs` function to compare spaces by DID ([#268](#268)) ([3dcd647](3dcd647))
* fix bug in `name` function ([#268](#268)) ([3dcd647](3dcd647))
* add createDelegation function to delegate access to spaces ([#293](#293)) ([441d757](441d757))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis@dag.house>
travis added a commit that referenced this pull request Feb 3, 2023
@github-actions @travis
chore(main): release react-keyring 2.1.0 (#372)
9cace63 
🤖 I have created a release *beep* *boop*
---


##
[2.1.0](react-keyring-v2.0.1...react-keyring-v2.1.0)
(2023-02-03)


### Features

* "Headless" UI components
([#136](#136))
([46583e0](46583e0))
* delegate access to spaces
([#293](#293))
([441d757](441d757))
* support `as` prop in uploader component
([#236](#236))
([c802e99](c802e99)),
closes [#235](#235)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@gmail.com>
Co-authored-by: Travis Vachon <travis@dag.house>
@github-actions github-actions bot mentioned this pull request Feb 3, 2023
Merged
travis added a commit that referenced this pull request Feb 8, 2023
@github-actions @travis
chore(main): release react-keyring 3.0.0 (#377)
c07b7a8 
🤖 I have created a release *beep* *boop*
---


##
[3.0.0](react-keyring-v2.1.0...react-keyring-v3.0.0)
(2023-02-06)


### ⚠ BREAKING CHANGES

* no breaking changes, but a major version bump because I made an error operating release-please

### Features

* "Headless" UI components
([#136](#136))
([46583e0](46583e0))
* delegate access to spaces
([#293](#293))
([441d757](441d757))
* import a space into w3console
([#309](#309))
([a69a95b](a69a95b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis@dag.house>
travis added a commit that referenced this pull request Feb 8, 2023
@github-actions @travis
chore(main): release solid-keyring 2.1.0 (#374)
cd09333 
🤖 I have created a release *beep* *boop*
---


##
[2.1.0](solid-keyring-v2.0.1...solid-keyring-v2.1.0)
(2023-02-06)


### Features

* delegate access to spaces
([#293](#293))
([441d757](441d757))
* import a space into w3console
([#309](#309))
([a69a95b](a69a95b))


### Bug Fixes

* get solid examples working again
([#199](#199))
([78ad7e9](78ad7e9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis@dag.house>
@github-actions github-actions bot mentioned this pull request Mar 21, 2023
Merged
travis pushed a commit that referenced this pull request Mar 23, 2023
@github-actions
chore(main): release w3console 1.0.0 (#416)
5650893 
🤖 I have created a release *beep* *boop*
---


## 1.0.0 (2023-03-23)


### ⚠ BREAKING CHANGES

* use new account model
([#400](#400))

### Features

* add terms of service page
([#417](#417))
([6deb24d](6deb24d))
* adds space-finder autocomplete combobox
([#268](#268))
([3dcd647](3dcd647))
* allow users to set page size in W3APIProvider
([#308](#308))
([814a293](814a293))
* club tropical w3 auth boxen
([#350](#350))
([2266eb2](2266eb2))
* delegate access to spaces
([#293](#293))
([441d757](441d757))
* import a space into w3console
([#309](#309))
([a69a95b](a69a95b))
* Improve upload component flow
([#285](#285))
([ba9a3bf](ba9a3bf))
* publish console to IPFS & Cloudflare from CI
([#287](#287))
([e2a833e](e2a833e))
* Storybook story improvements
([#294](#294))
([e0de2cc](e0de2cc))
* use new account model
([#400](#400))
([66dd20b](66dd20b))
* w3console example app
([#255](#255))
([df08029](df08029))


### Bug Fixes

* add _headers ([#418](#418))
([4eb1da1](4eb1da1))
* fix w3console styling
([#320](#320))
([74a298c](74a298c))
* remove authenticator class when registed
([#352](#352))
([3668f3b](3668f3b))
* w3console polish
([#284](#284))
([9a67365](9a67365))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travis travis travis approved these changes

@alanshaw alanshaw Awaiting requested review from alanshaw

Assignees

@olizilla olizilla

Labels
None yet
Projects
None yet
Milestone
w3up phase 2
Development

Successfully merging this pull request may close these issues.
2 participants
@olizilla @travis