Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): re-enable tokens endpoints outside read-write #2374

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

hannahhoward
Copy link
Contributor

Goals

Re-enable creating API tokens

Implementation

Currently the whole API is in read only mode. This allows tokens to be created and deleted by moving the handler outside the read/write mode protections

@hannahhoward hannahhoward requested a review from a team as a code owner February 14, 2025 16:51
Copy link

@travis travis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems right?!

@hannahhoward hannahhoward merged commit 2aff012 into main Feb 14, 2025
4 of 5 checks passed
@hannahhoward hannahhoward deleted the fix/reenable-tokens branch February 14, 2025 18:03
hannahhoward pushed a commit that referenced this pull request Feb 14, 2025
🤖 I have created a release *beep* *boop*
---


##
[7.25.1](api-v7.25.0...api-v7.25.1)
(2025-02-14)


### Bug Fixes

* **api:** re-enable tokens endpoints outside read-write
([#2374](#2374))
([2aff012](2aff012))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants