Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support any IPLD decoder #365

Merged
merged 1 commit into from
Aug 18, 2021
Merged

feat: support any IPLD decoder #365

merged 1 commit into from
Aug 18, 2021

Conversation

alanshaw
Copy link
Member

This PR adds an optional parameter to putCar called decoders. It's an array of IPLD BlockDecoder.

It's needed when the DAG in the CAR file was not encoded using the default encoders dag-pb, dag-cbor and raw.

vasco-santos
vasco-santos approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It would be good to have an example, can you create an issue to have it created later on?

@alanshaw alanshaw mentioned this pull request Aug 18, 2021
Closed
@alanshaw
Copy link
Member Author

It would be good to have an example, can you create an issue to have it created later on?

Good idea!

#367

@alanshaw alanshaw merged commit 406d227 into main Aug 18, 2021
@alanshaw alanshaw deleted the feat/support-any-ipld-decoder branch August 18, 2021 14:12
@alanshaw alanshaw mentioned this pull request Oct 12, 2021
Merged
@github-actions github-actions bot mentioned this pull request Jan 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasco-santos vasco-santos vasco-santos approved these changes

@olizilla olizilla Awaiting requested review from olizilla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanshaw @vasco-santos