lint and feedback

Author: Alex Luu

packages/web3-core/src/web3_request_manager.ts

@@ -210,7 +210,7 @@ export class Web3RequestManager<
 		) as JsonRpcPayload;
 
 		if (!isNullish(this.middleware)) {
-			payload = (await this.middleware.processRequest(payload));
+			payload = await this.middleware.processRequest(payload);
 		}
 		if (isWeb3Provider(provider)) {
 			let response;
@@ -241,14 +241,14 @@ export class Web3RequestManager<
 						payload,
 						error as JsonRpcResponse<ResponseType, unknown>,
 						{ legacy: true, error: true },
-					)
+					),
 				);
 		}
 
 		// TODO: This could be deprecated and removed.
 		if (isLegacyRequestProvider(provider)) {
 			return new Promise<JsonRpcResponse<ResponseType>>((resolve, reject) => {
-				const rejectWithError = (err: unknown) =>{
+				const rejectWithError = (err: unknown) => {
 					reject(
 						this._processJsonRpcResponse(
 							payload,
@@ -257,9 +257,10 @@ export class Web3RequestManager<
 								legacy: true,
 								error: true,
 							},
-						))
-				}
-					
+						),
+					);
+				};
+
 				const resolveWithResponse = (response: JsonRpcResponse<ResponseType>) =>
 					resolve(
 						this._processJsonRpcResponse(payload, response, {
@@ -290,18 +291,18 @@ export class Web3RequestManager<
 						JsonRpcResponse<ResponseType>
 					>;
 					responsePromise.then(resolveWithResponse).catch(error => {
-							try {
-								// Attempt to process the error response
-								const processedError = this._processJsonRpcResponse(
-									payload,
-									error as JsonRpcResponse<ResponseType, unknown>,
-									{ legacy: true, error: true }
-								);
-								reject(processedError);
-							} catch (processingError) {
-								// Catch any errors that occur during the error processing
-								reject(processingError);
-							}
+						try {
+							// Attempt to process the error response
+							const processedError = this._processJsonRpcResponse(
+								payload,
+								error as JsonRpcResponse<ResponseType, unknown>,
+								{ legacy: true, error: true },
+							);
+							reject(processedError);
+						} catch (processingError) {
+							// Catch any errors that occur during the error processing
+							reject(processingError);
+						}
 					});
 				}
 			});

packages/web3-core/test/unit/web3_request_manager.test.ts

@@ -281,20 +281,6 @@ describe('Web3RequestManager', () => {
 			expect(await pr).toBe('test');
 		});
 
-		it('promise of legacy provider should be error', async () => {
-			const manager = new Web3RequestManager(undefined, undefined);
-			const pr = new Promise(resolve => {
-				resolve('test');
-			});
-			const myProvider = {
-				request: jest.fn().mockImplementation(async () => pr),
-			} as any;
-			manager.setProvider(myProvider);
-			await manager.send(request);
-			expect(myProvider.request).toHaveBeenCalledTimes(1);
-			expect(await pr).toBe('test');
-		});
-
 		it('Got a "nullish" response from provider', async () => {
 			const manager = new Web3RequestManager(undefined, undefined);
 			const myProvider = {
@@ -1150,12 +1136,11 @@ describe('Web3RequestManager', () => {
 			});
 
 			it('should error in isPromise', async () => {
-
 				const manager = new Web3RequestManager();
 				const myProvider = {
 					request: jest
 						.fn()
-						.mockImplementation((async () => Promise.reject(errorResponse))),
+						.mockImplementation(async () => Promise.reject(errorResponse)),
 				} as any;
 
 				jest.spyOn(manager, 'provider', 'get').mockReturnValue(myProvider);

packages/web3-eth/src/rpc_method_wrappers.ts

@@ -581,7 +581,7 @@ export function sendTransaction<
 							transaction,
 							transactionFormatted,
 						});
-						
+
 						await sendTxHelper.checkRevertBeforeSending(
 							transactionFormatted as TransactionCall,
 						);

packages/web3/test/integration/external-providers/helper.ts

@@ -38,15 +38,15 @@ export async function performBasicRpcCalls(provider: SupportedProviders) {
 		to: accounts[1],
 		from: accounts[0],
 		value: '1',
-		gas: 21000
+		gas: 21000,
 	});
 	expect(tx.status).toBe(BigInt(1));
 
 	const blockNumber1 = await web3.eth.getBlockNumber();
 	expect(typeof blockNumber1).toBe('bigint');
 
 	// After sending a transaction, the blocknumber is supposed to be greater than or equal the block number before sending the transaction
-	expect(blockNumber1).toBeGreaterThanOrEqual(blockNumber0);	
+	expect(blockNumber1).toBeGreaterThanOrEqual(blockNumber0);
 }
 
 export async function failErrorCalls(provider: SupportedProviders) {
@@ -57,7 +57,7 @@ export async function failErrorCalls(provider: SupportedProviders) {
 		provider,
 	});
 
-	let deployOptions: Record<string, unknown>;;
+	let deployOptions: Record<string, unknown>;
 
 	// eslint-disable-next-line prefer-const
 	deployOptions = {
@@ -68,9 +68,7 @@ export async function failErrorCalls(provider: SupportedProviders) {
 
 	const sendOptions = { from: accounts[0], gas: '1000000' };
 
-
 	contract = await contract.deploy(deployOptions).send(sendOptions);
 
-	await contract.methods.reverts().send({ from: accounts[0] })
-	
-}
+	await contract.methods.reverts().send({ from: accounts[0] });
+}