-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0] account management API questions #1113
Comments
|
Hello @frozeman , I may be interested in working on HD Wallet support. It could be built on bitcore-lib (for the HD wallet) and bitcore-mnemonic (for the BIP39 seedphrase) Not sure what your ideas would on how to integrate this stuff. It could either replace the address generation code of the wallet, i.e. to have |
@jellegerbrandy @frozeman |
@jellegerbrandy Feel free to submitt a PR with a TransactionSigner object. We could add the possibility to pass a string like |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions |
First of all, it is great to see account management API made it to web3, I think it will go a long way to reduce friction for dapp development.
A few questions to make sure I understand the idea behind the design:
provider
, it didn't seem to be one for accounts. Most of the wallets out there used provider interface to inject its own accounts. It's a necessary evil before, but now with the modular accounts API, I wonder would it make sense to split extension points and allow accounts to be customized independent of the provider? (better for composition and less monolithic)The text was updated successfully, but these errors were encountered: