Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscribe(“logs”) only returns first log #1322

Closed
mikemcdonald opened this issue Jan 26, 2018 · 1 comment
Closed

subscribe(“logs”) only returns first log #1322

mikemcdonald opened this issue Jan 26, 2018 · 1 comment

Comments

@mikemcdonald
Copy link

https://github.com/ethereum/web3.js/blob/2386448e3068e98ebeb671f62f142b24d65ba79e/packages/web3-core-subscriptions/src/subscription.js#L258-L259

Is this ready to be updated so the full array of logs is returned? I saw the note about removing these lines once fixed in geth

@AC0DEM0NK3Y
Copy link

AC0DEM0NK3Y commented Mar 15, 2018

Please update on this, I just found an issue that looks like it stems from this i.e. if you are subscribed and multiple events occur in the same mined block, you only get the first event data.

edit: I commented out those two lines and my code works now (after altering to accept an array). This is with parity running locally however not geth.

edit again: 1.0.0-beta.31 looks to have solved this.

@nivida nivida closed this as completed Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants