-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong network ID and network type #2239
Labels
Bug
Addressing a bug
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
web3.eth.net.getId()
should callnet_version
and return the current network id.https://github.com/ethereum/web3.js/blob/1d9f6c0889c7f551b4ec1041cece0d50bc3ff2c8/packages/web3-net/src/index.js#L38-L43
Actual behavior
From 1.0.0-beta.38 onwards,
web3.eth.net.getId
callseth_protocolVersion
and returns the current ethereum protocol version.https://github.com/ethereum/web3.js/blob/10face700362d124bc877ba6ea1390bde8364447/packages/web3-core-method/src/methods/network/VersionMethod.js#L25-L34
Steps to reproduce the behavior
Versions
web3.js
1.0.0-beta.38
and1.0.0-beta.39
The text was updated successfully, but these errors were encountered: