-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typescript] Account interface does not seems to be right #2374
Comments
Hey @oktapodia Thanks for raising this looking at it you are correct. In actual fact the documents are incorrect as well https://web3js.readthedocs.io/en/1.0/web3-eth-accounts.html#signtransaction I think it needs to be
as it gets your private key from your account so the typing's should be above. I will do a PR later on and update the docs to be inline with the code. good spot! |
Awesome! Let me know if you need any help on that |
Hey sorry about the delay i have been away from my computer. It is fixed in this PR and will be released within the next release - thanks again for the issue raised. |
All issues which aren't created with this template will get immediately closed.
Hello,
I'm not sure the typing
Account.signTransaction
interface is correct here, should be that isn't it?Expected behavior
source
or similar
Actual behavior
source
Steps to reproduce the behavior
>1.0.0-beta.36
Account
typing definitionError Logs
Expected 1 arguments, but got 2.ts(2554)
Versions
Typescript latest
npm latest
The text was updated successfully, but these errors were encountered: