Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new Contract(abi, web3Context) doesn't apply context to instance #5802

Closed
1 task done
spacesailor24 opened this issue Feb 2, 2023 · 2 comments
Closed
1 task done
Assignees
Labels
4.x 4.0 related Bug Addressing a bug

Comments

@spacesailor24
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

const web3Context = new Web3Context('http://127.0.0.1:8545');
const contract = new Contract(abi, web3Context);

Should apply web3Context to contract instance, but this context argument is never used within the constructor

Expected Behavior

new Contract(abi, web3Context); applied the given context to the Contract instance

Steps to Reproduce

const web3Context = new Web3Context('http://127.0.0.1:8545');
const contract = new Contract(abi, web3Context);

Web3.js Version

4.x.x

Environment

No response

Anything Else?

No response

@spacesailor24 spacesailor24 added Bug Addressing a bug 4.x 4.0 related labels Feb 2, 2023
@kevinam99
Copy link

Opened #5850 to fix this

@jdevcs
Copy link
Contributor

jdevcs commented Mar 28, 2023

@spacesailor24 PR is merged so closing it. can you update its estimate for sprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related Bug Addressing a bug
Projects
None yet
Development

No branches or pull requests

4 participants