Add raw hash signing function (without the wrapping in Ethereum message: ...)

[mconnelly8]

No description provided.

[jdevcs]

https://docs.web3js.org/libdocs/Accounts#sign

[jdevcs]

scope: add function, doc, unit test ( with recovery )

[blackmoshui]

@jdevcs Hey, is anyone working on this? I'd love to try this one. I plan to add one more option parameter into the hashMessage to add support for whether there is a prefix or not.

web3.js/packages/web3-eth-accounts/src/account.ts

Line 159 in f701406

export const hashMessage = (message: string): string => {

Overall, should we introduce new function pairs, such as signRaw/recoverRaw, or modify the logic of the existing sign/recover?

The latter might introduce breaking changes, because the current prefixed param of recover actually combines whether to hash and add a prefix. If we modify the existing functionality, this logic might change.

web3.js/packages/web3-eth-accounts/src/account.ts

Line 424 in f701406

const hashedMessage = prefixedOrR ? data : hashMessage(data);

[jdevcs]

@blackmoshui thanks for your contribution, We will prefer to avoid breaking change.

[mconnelly8]

Hey @blackmoshui, just wanted to confirm that you want to implement this? Let us know if you have any questions. The main thing we want to ensure is that we want to avoid breaking changes.

[blackmoshui]

Hey @blackmoshui, just wanted to confirm that you want to implement this? Let us know if you have any questions. The main thing we want to ensure is that we want to avoid breaking changes.

I understand that avoiding breaking changes in a client-side SDK is very important.

I plan to add an optional parameter to hashMessage to support not adding a prefix, then add a new signRaw function along with corresponding tests and documentation.

In the initial PR, I won't add functions like recoverRaw because users can combine existing hashMessage and recover functions to implement recovery themselves. I believe this approach won't introduce any breaking changes.

What do you think? I can prepare a draft PR first.

[mconnelly8]

@jdevcs?

[blackmoshui]

I prepared a PR, but after completing it I realized that we could also achieve this functionality by modifying the existing sign function instead of adding a new function. I can modify the PR if needed.