[plugin] customTransactionSchema follow-up

[nicolasbrugneaux]

Greetings! Thanks again for merging my work in

• feat: add custom transaction schema to formatTransaction #7227

Sadly, it's still not enough to allow for extra fields in transactions. Indeed, this function getEthereumjsTxDataFromTransaction is trimming down fields despite being validated earlier

[nicolasbrugneaux]

I'm happy to propose changes but I just wanted to get your opinion on what you think should happen, I believe the function is somewhat redudant and could be limited to field aliasing (data<->input, gas<->gasLimit)

[jdevcs]

@nicolasbrugneaux considering getEthereumjsTxDataFromTransaction is used

web3.js/packages/web3-eth/src/utils/prepare_transaction_for_signing.ts

Line 150 in 6f9a485

getEthereumjsTxDataFromTransaction(formattedTransaction),

I think it can be modified to use alias for (data<->input, gas<->gasLimit) and spread all existing other fields from the transaction to return obj.

[aaronmgdr]

what about a test in web3 like "allows for plugins to add new tx fields" to make sure this works and prevent regressions

[nicolasbrugneaux]

• feat: make getEthereumjsTxDataFromTransaction not trim extra fields #7282