Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dapps cannot connect my wallet by using BrowserViewController with a URL. #357

Closed
AlleniCode opened this issue Aug 9, 2021 · 9 comments
Closed
Labels
bug Something isn't working

Comments

@AlleniCode
Copy link

When I entered a dapp page with BrowserViewController, it cannot connect my wallet automatically.

https://github.com/skywinder/web3swift/blob/develop/Example/web3swiftBrowser/web3swiftBrowser/ViewController.swift

class DAppsViewController: BrowserViewController {

    override func viewDidLoad() {
        super.viewDidLoad()
    }

    override func viewWillAppear(_ animated: Bool) {
        super.viewWillAppear(animated)

        webView.translatesAutoresizingMaskIntoConstraints = false
        view.addSubview(webView)

        NSLayoutConstraint.activate([
            webView.topAnchor.constraint(equalTo: view.topAnchor),
            webView.leadingAnchor.constraint(equalTo: view.leadingAnchor),
            webView.trailingAnchor.constraint(equalTo: view.trailingAnchor),
            webView.bottomAnchor.constraint(equalTo: view.bottomAnchor),
        ])

        var urlToOpen = "https://1inch.exchange/"
        urlToOpen = "https://app.compound.finance"
        urlToOpen = "https://app.uniswap.org"
        webView.load(URLRequest(url: URL(string: urlToOpen)!))

        do {
            let keystoreManager = KeystoreManager(["My EthereumKeystoreV3"])
            let web3 = Web3.InfuraMainnetWeb3()
            web3.addKeystoreManager(keystoreManager)
            
            self.registerBridges(for: web3)
        } catch {
            print(error)
        }
    }
}

Same issues:

#338
#337
#321
#304
#303

@skywinder

@RaviRanjan-11
Copy link
Contributor

https://github.com/veerChauhan/web3swift

Go through the Example #Web3supportBrowser

#338 #337
#321
#304
#303

Please let me know if there any issue

@AlleniCode
Copy link
Author

@veerchauhan Hello, I have tried,still the same issue. 😂

@skywinder skywinder added bug Something isn't working help wanted Extra attention is needed 💸 gitcoin-bounty Earn money by helping with this issue! labels Aug 13, 2021
@skywinder
Copy link
Collaborator

Thank the report.
I'm not able to check It right now but would be happy to allocate gitcoin bounty for someone who can fix it.

@skywinder
Copy link
Collaborator

skywinder commented Aug 13, 2021

Here you go, here is a bounty: https://gitcoin.co/issue/skywinder/web3swift/357/100026264 - I'm open to adjusting bounty if it takes time.
Let me know if someone is willing to help with this. 🙌

@CYC666
Copy link

CYC666 commented Aug 20, 2021

🙁

@AlleniCode
Copy link
Author

@skywinder Is this issue solved?

@CYC666
Copy link

CYC666 commented Dec 2, 2021

I've solved the question that cann't connect DApp.

You can add my WeChat who want to get the idea.

My WeChat ID: wxid-74skhl3tr69k21

@Valter4578
Copy link
Contributor

Valter4578 commented Dec 30, 2021

I've solved the question that cann't connect DApp.

You can add my WeChat who want to get the idea.

My WeChat ID: wxid-74skhl3tr69k21
@CYC666 Hello. Can you provide your solution for this issue here please

@yaroslavyaroslav yaroslavyaroslav removed help wanted Extra attention is needed 💸 gitcoin-bounty Earn money by helping with this issue! labels Oct 23, 2022
@yaroslavyaroslav yaroslavyaroslav closed this as not planned Won't fix, can't repro, duplicate, stale Oct 23, 2022
@sathyawealwin
Copy link

sathyawealwin commented Jan 7, 2023

https://github.com/veerChauhan/web3swift

Go through the Example #Web3supportBrowser

#338 #337 #321 #304 #303
IMG_39CBC6432732-1

Please let me know if there any issue

injected not show when I click the connect button on dapps.
It's looks like normal browser. I expect above shared screenshot . Kindly help me .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants