-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with in-repo-engines (i.e. addons) using pods structure and podModulePrefix #295
Comments
I seem to have similar issue, but with components belonging to the main application. |
@dguettler hmm.. are these route styles? or component styles.. |
@AndreJoaquim Were you able to fix this issue? I'm having a similar issue. |
@peiris Nope :( |
Are you reexporting in the “app” space in a pod or classic structure? |
and i’d leave off the prefix in the structure inside of the “addon” space. |
but i thought i had fixed this. :( |
After a long talk/debugging session with @webark, we found out that there's an issue using this addon in in-repo-engines that have the pods structure.
The issue is that the file containing the styles and the auto-generated classes exists but the auto-generated class names are not injected in the HTML DOM elements.
Below, I leave my in-repo-engine structure and the
config/environment.js
file (including the podModulePrefix)in-repo-engine (
![screen shot 2018-09-05 at 18 33 38](https://user-images.githubusercontent.com/5813769/45110463-3cbc6800-b13a-11e8-8129-75c83a6f113e.png)
neighborhood-page
) structure@webark was really helpful and I'll post some of the results of our debugging:
Q1: See if the components you are expecting are in this..
![screen shot 2018-09-05 at 17 57 30](https://user-images.githubusercontent.com/5813769/45110510-6ecdca00-b13a-11e8-8864-e53ea288bcc3.png)
window.requirejs.entries['ember-component-css/pod-names'].module.exports.default
A1:
Q2: Run
find . -name "pod-names.js" -path "*/addon/*"
in your root, and see how many files get outputtedA2: the console outputs the following:
./node_modules/ember-component-css/addon/pod-names.js
Q3: What's the path of that component in the addon directory? What's the path in the app directory? How are you calling it from the template? In the addon componet.js file you are manually setting the layout right?
Q3:
/addon/np-description/component.js
;/lib/neighborhood-page/addon/np-description/component.js
;lib/neighborhood-page/addon/pods/index/template.hbs
->{{np-description neighborhoodPage=model.neighborhoodPage}}
; Yes.Q4: By taking off the podModulePrefix and putting all the pods under
/addon
(i.e. moving all the folders from/addon/pods
to/addon
) does it work?Q4: Yes, it works
Last considerations: @webark, thanks so much for your help, you're super awesome!
Just wanted to say that this addon is freaking awesome and I use it in all of our platforms 🙂
It’s so awesome that it was the first thing I added to my first in-repo-engine 😄
The text was updated successfully, but these errors were encountered: