Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use emojione emoji images #260

Closed
miketaylr opened this issue Sep 11, 2014 · 7 comments
Closed

Use emojione emoji images #260

miketaylr opened this issue Sep 11, 2014 · 7 comments

Comments

@miketaylr
Copy link
Member

https://github.com/Ranks/emojione

Right now we just cough link to somebody else's when we do Markdown2Emoji conversion.

@miketaylr
Copy link
Member Author

A new contender: http://twitter.github.io/twemoji/

@karlcow
Copy link
Member

karlcow commented Nov 10, 2014

Instead of converting to images, could we just convert to the "right" unicode character?

Images are cool, but they imposed a representation on people and they create HTTP requests for nothing much.

@miketaylr
Copy link
Member Author

@karlcow that would be better for user agents that support emoji unicode. To investigate: if Twitter's lib can feature detect rather than force images on everyone.

The big elephant with emoji is that Chrome and Android stock browsers do not support them. :/ That's why all these image solutions/hacks exist.

See http://caniemoji.com/android/

@miketaylr miketaylr added this to the Unprioritized issues milestone Dec 3, 2014
@miketaylr
Copy link
Member Author

Chrome finally added support: https://twitter.com/addyosmani/status/543520233294942209

But Android is still an issue and Chrome will be for a few months until their users are upgraded.

@miketaylr
Copy link
Member Author

I think it's probably good enough to just use Twitter's emoji image CDN (which is allowed): e.g., https://twemoji.maxcdn.com/36x36/2764.png

@karlcow
Copy link
Member

karlcow commented Dec 19, 2014

I would be in favor of just not pushing images for emojis. I don't think we gain a lot with it. And I prefer we stay with real characters. But that's my 2 cents. ;)

@miketaylr
Copy link
Member Author

OK. As an experiment we're only going to be serving the real unicode emoji chars, as part of #604. If someone opens a bug complaining about emoji support for older browsers we'll re-open this one and either use emojione or twemoji. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants