-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid scaling images #2810
Comments
|
It comes from a performance tool I was using http://sitespeed.io/
I imagine that it's related to change of layout? Or maybe it's because we fetch the image from github and it doesn't fit our page and then we have to resize it. I really don't know for sure. |
Yes any responsive design sites are scaling images. But each time someone post comments through GitHub and upload images, then we have no control on the image size. And we can't do anything about it (except post comment editing by webcompat-bot but I don't think it's worth the work and the tampering). It's part of the constraints of our model. |
Yeah. Okay, seems like you've already made an otsukare here @karlcow. Thanks! |
"Scaling images in the browser takes extra CPU time and will hurt performance on mobile. And the user will download extra kilobytes (sometimes megabytes) of data that could be avoided."
One way to fix it is create multiple version of the same image server-side and serve the appropriate one. But I don't think that's appropriated at all for our website.
@miketaylr said it's relevant to improve performance on the single issue page and I think we could try to look at how images are being rendered at the website. Currently we have this scaling image problem that I don't know if can be fixed, but I'll explore more about this subject and post what I find in this issue.
The text was updated successfully, but these errors were encountered: