Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues Page #481

Closed
andrewmcgivery opened this issue Dec 13, 2014 · 1 comment
Closed

Issues Page #481

andrewmcgivery opened this issue Dec 13, 2014 · 1 comment
Assignees
@miketaylr
Milestone
Accessibility

Comments

@andrewmcgivery
Copy link
Contributor

Not sure how I didn't notice this before, for the issues list page has NO headings. This is not ideal from an accessibility perspective and it throwing a warning.

Could we perhaps turn the "View all Open Issues" into an H1?

<span class="Dropdown-label">View all Open Issues</span>

to

<h1 class="Dropdown-label">View all Open Issues</h1>
@miketaylr miketaylr added this to the Accessibility milestone Dec 17, 2014
@miketaylr
Copy link
Member

Yep, this should be doable. Thanks for flagging this.

@miketaylr miketaylr self-assigned this Dec 17, 2014
miketaylr pushed a commit that referenced this issue Dec 17, 2014
Issue #481 - Use h1 for issues page dropdown heading.
43d12c0
miketaylr pushed a commit that referenced this issue Dec 17, 2014
Issue #481 - Use h1 for issues page dropdown heading.
6a744d0
miketaylr pushed a commit that referenced this issue Dec 18, 2014
Merge pull request #495 from /issues/481/1
daffaad 
Issue #481 - Use h1 for issues page dropdown heading.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketaylr miketaylr

Labels
None yet
Projects
None yet
Milestone
Accessibility
Development

No branches or pull requests
2 participants
@miketaylr @andrewmcgivery