-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tablet info to browser name #821
Comments
To fix this bug, you'll probably want to add some logic to https://github.com/webcompat/webcompat.com/blob/master/webcompat/form.py#L106 Code that sets a label on an issue:
(But it occurs to me that might be theoretical, I'm not sure I changed the endpoints in GitHub yet 👻) |
And for it to work at that point, we need to add a label to the web-bugs repo "firefox-mobile-tablet" (or similar, just has to match what we send to GitHub). |
@dshgna want to take a look at this bug? |
@miketaylr working on it! Made an initial commit in #941 to check if I'm moving in the right direction. Is there a way that I can simulate different devices when testing? I tried the responsive view in Firefox dev tools, but it doesn't change the user agent. |
See #819 (comment).
The idea would be if we have
device.model == 'Tablet'
, we add a(Tablet)
after the browser name. Just need to investigate how other tablet browsers are currently displayed so we don't do something silly likeChrome Tablet (Tablet)
.The text was updated successfully, but these errors were encountered: