Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixing same name but with different case is causing issues with the file/class exporer #181

Closed
obiot opened this issue Jul 10, 2022 · 5 comments · Fixed by #183
Closed

Comments

@obiot
Copy link

obiot commented Jul 10, 2022

we have this file : https://github.com/melonjs/melonJS/blob/master/src/system/timer.js

where Timer (T uppercase) is a class, and timer (t lowercase) is a "global" instance of Timer.

when generating the documentation, the explorer never returns the proper page for timer but instead displays the Timer one. both are however correctly visible as :

  • timer (namespace)
  • Timer

Note: the current version of the documentation online is not correct either, and I realised this issue when fixing the JSDoc tags for it

@ShukantPal
Copy link
Member

Hmm seems like a case sensitive url conflict. I bet there are 2 html pages timer.html and Timer.html?

@obiot
Copy link
Author

obiot commented Jul 11, 2022

I wish it was that "simple" but :

  • only timer.html is generated
  • timer.html actually contains what should be in Timer.html (timer content is never generated)
  • I'm on MacOS, no case sensitive issue when accessing files :)

@obiot
Copy link
Author

obiot commented Jul 13, 2022

Hi @ShukantPal any chance this one could be an easy fix ? I was hoping to release the current 13.0 version soon, but then I have this documentation issue after refactoring the time/Time related code :)

thanks !

@ShukantPal
Copy link
Member

Yeah I plan on fixing & release a new version this weekend

@obiot
Copy link
Author

obiot commented Jul 13, 2022

awesome !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants