Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture the hook name in the json report, which is a new feature of cucumber-js #94

Closed
dietergeerts opened this issue May 6, 2022 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@dietergeerts
Copy link

dietergeerts commented May 6, 2022

Is your feature request related to a problem? Please describe.
When creating E2E test reports, all hooks have an empty name, which can be hard in debugging.

Describe the solution you'd like
The @cucumber/cucumber package has done an update and added a feature to add a hook name. It would be great if this name gets into the json report, so that the html report can on his turn use it further.
cucumber/cucumber-js#1079 (comment)

Describe alternatives you've considered
There isn't an alternative for this. Before, it just wasn't possible, now it is.

Additional context
Currently, this is a report we get, to make clear how difficult it can be when one fails and need to find out which one. (this is the html report from a reporter that uses the json result from this reporter. I checked, and the name isn't filled in.)
image

@christian-bromann
Copy link
Contributor

Thanks for reporting!

Any contributions that implement this are highly appreciated. Don't expect this to be picked up by active contributors as they have their own priorities. If you depend on this bug to be fixed, your contribution is required. Please take a look into our contribution guidelines or join our Discord development server and let us know if you have any questions. Cheers!

@christian-bromann christian-bromann added the help wanted Extra attention is needed label May 4, 2023
@ghost
Copy link

ghost commented Aug 24, 2023

From what I investigated, it seems that the issue doesn't come from this package. I looked in wdio-cucumber-framework and investigations leaded me to an issue already logged to webdriverio/webdriverio#8324

So it confirms that you won't have the name yet in json report and that it should be solve out of this package.

@ghost
Copy link

ghost commented Sep 5, 2023

This is fixed by webdriverio/webdriverio#8324

I tested it OK after upgrading wdio to the last v8.16

@christian-bromann
Copy link
Contributor

Awesome 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants