v7 (#559)

* v7

Author: mgrybyk

.eslintrc.js

@@ -1,7 +1,7 @@
 module.exports = {
   root: true,
   parserOptions: {
-    ecmaVersion: 2017,
+    ecmaVersion: 2019,
   },
   plugins: ['prettier'],
   extends: ['eslint:recommended', 'prettier', 'plugin:prettier/recommended'],

.github/workflows/test.yml

@@ -0,0 +1,38 @@
+name: Test
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+
+jobs:
+  linux:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node-version: ['12.x', '14.x', '16.x']
+        java: ['11']
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-java@v2
+        with:
+          distribution: 'adopt'
+          java-version: ${{ matrix.java }}
+      - uses: actions/setup-node@v1
+        with:
+          node-version: ${{ matrix.node-version }}
+      - uses: actions/cache@v2
+        id: cache
+        with:
+          path: '**/node_modules'
+          key: ${{ runner.os }}-${{ matrix.node-version }}-node_modules-${{ hashFiles('**/package-lock.json') }}
+      - name: Install Dependencies
+        if: steps.cache.outputs.cache-hit != 'true'
+        run: npm ci
+      - name: Lint
+        run: npm run lint
+      - name: Test
+        run: npm run test
+        env:
+          CI: true

.travis.yml

@@ -1,7 +1,5 @@
 FROM ubuntu:latest@sha256:aba80b77e27148d99c034a987e7da3a287ed455390352663418c0f2ed40417fe
 
-ENV NODE_VERSION 8.11.2
-
 LABEL author="Vincent Voyer <vincent@zeroload.net>"
 LABEL maintainer="Serban Ghita <serbanghita@gmail.com>"
 
@@ -35,7 +33,7 @@ RUN apt-get -qqy --no-install-recommends install \
   nodejs \
   firefox \
   google-chrome-stable \
-  openjdk-8-jre-headless \
+  openjdk-11-jre-headless \
   xvfb \
   xfonts-100dpi \
   xfonts-75dpi \

Dockerfile

@@ -1,3 +1,12 @@
+# 7.0.0 (2021-06-18)
+* BREAKING CHANGE drop nodejs 10, minimum version is 12
+* BREAKING CHANGE removed callbacks for `install` and `start` commands
+* BREAKING CHANGE `install` and `start` commands are Promises now!
+* BREAKING CHANGE docker images are built with `jdk11`
+* BREAKING CHANGE dropped support of old browser drivers and platforms
+* BREAKING CHANGE change folder structure #491
+* check port before starting selenium #553
+
 # 6.24.0 (2021-06-16)
 * selenium 4 support
 * update default versions

HISTORY.md

@@ -1,7 +1,6 @@
 <!-- START doctoc generated TOC please keep comment here to allow auto update -->
 <!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
 
-
 - [selenium-standalone](#selenium-standalone)
   - [Install & Run](#install--run)
   - [Command line interface (CLI)](#command-line-interface-cli)
@@ -14,7 +13,6 @@
 <!-- END doctoc generated TOC please keep comment here to allow auto update -->
 
 # selenium-standalone 
-[![Build Status](https://travis-ci.org/vvo/selenium-standalone.svg?branch=master)](https://travis-ci.org/vvo/selenium-standalone) 
 [![dependencies Status](https://david-dm.org/vvo/selenium-standalone/status.svg)](https://david-dm.org/vvo/selenium-standalone)
 [![devDependencies Status](https://david-dm.org/vvo/selenium-standalone/dev-status.svg)](https://david-dm.org/vvo/selenium-standalone?type=dev)
 

README.md

@@ -11,54 +11,33 @@ const path = require('path');
 const selenium = require('../');
 const defaultConfig = require('../lib/default-config')();
 
+if (!process.listeners('unhandledRejection').length === 0) {
+  process.on('unhandledRejection', (reason) => {
+    console.error(reason);
+  });
+}
+
 const actions = {
-  start: function (options) {
+  start: async function (options) {
     const killEvents = ['exit', 'SIGTERM', 'SIGINT'];
+    const cp = await selenium.start(options);
 
-    selenium.start(options, started);
-
-    function started(err, cp) {
-      if (err) {
-        if (cp) {
-          cp.kill('SIGINT');
-        }
-        throw err;
-      }
-
-      console.log('Selenium started');
-
-      killEvents.forEach(register);
-
-      function register(evName) {
-        process.on(evName, kill);
-      }
+    console.log('Selenium started');
 
-      function unregister(evName) {
-        process.removeListener(evName, kill);
-      }
+    killEvents.forEach((evName) => {
+      process.once(evName, () => cp.kill('SIGTERM'));
+    });
 
-      function kill() {
-        killEvents.forEach(unregister);
-        cp.kill('SIGTERM');
-      }
-    }
+    return cp;
   },
-  install: function (options) {
+  install: async function (options) {
     const ProgressBar = require('progress');
     let bar;
     let firstProgress = true;
 
     // eslint-disable-next-line no-param-reassign
     options.progressCb = options.silent ? null : progressCb;
 
-    selenium.install(options, installed);
-
-    function installed(err) {
-      if (err) {
-        throw err;
-      }
-    }
-
     function progressCb(total, progress, chunk, url, reset) {
       if (firstProgress) {
         console.log('');
@@ -77,6 +56,8 @@ const actions = {
 
       bar.tick(chunk);
     }
+
+    await selenium.install(options);
   },
 };
 

bin/selenium-standalone

@@ -10,7 +10,7 @@ LABEL maintainers="Serban Ghita <serbanghita@gmail.com>, David Catalan <catalan.
 ENV LC_ALL=C
 ENV DISPLAY=:99
 ENV SELENIUM_CONSOLE_URL=http://localhost:4444/wd/hub
-ENV SCREEN_GEOMETRY=1024x768x16
+ENV SCREEN_GEOMETRY=1920x1080x16
 
 
 # Expose Selenium web console port
@@ -29,7 +29,7 @@ RUN apt-get -qqy install \
     jq \
     software-properties-common \
     sudo \
-    openjdk-8-jre-headless \
+    openjdk-11-jre-headless \
     wget \
     xvfb \
     xfonts-100dpi \

bin/start-selenium

@@ -35,7 +35,7 @@ $ docker run -it -p 4444:4444 vvoyer/selenium-standalone
 
 * `SCREEN_GEOMETRY` Set browser window size
   * Format: `<WIDTH>x<HEIGHT>x<DEPTH>`
-  * Default: `1024x768x16`
+  * Default: `1920x1080x16`
   * Usage example: set screen size to 1200x1200 with 8bits depth
     ```
     $ docker run -it -p 4444:4444 -e SCREEN_GEOMETRY="1200x1200x8" vvoyer/selenium-standalone