-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http-compression prefers zopfli over brotli #1244
Comments
@GuillaumeRossolini Thank you for taking the time to open this issue.
The However, you should also keep in mind that servers should respect the request headers. If the user agent advertises that it only supports gzip (even over HTTPS), then the server shouldn't respond with something that is not gzip compatible (such as Brotli). In your case, it wasn't that it preferred gzip/Zopfli over Brotli, it probably just saw that:
Hope that that makes things clear. https://webhint.io/scanner/da70cbb9-a1c5-4f8f-9911-436607af5cd4 @GuillaumeRossolini Good work on reducing the issues! 🎉 |
I forgot to say that
The part that makes sense is:
|
@GuillaumeRossolini I do apologize, but I don't really understand how to interpret your last comment. Are things clear now, or do you still think something is not recommended correctly? |
Yes, your first comment explained why I got this warning. Thank you. |
Hi,
[It was suggested to me on Twitter that I open an issue for this.]
At my company, we compress our assets different ways: first gzip, then brotli and lzma, and finally we overwrite the gzip file with a zopfli version.
Our compression pipeline was broken for a while, so gzip and brotli worked fine but zopfli and lzma didn't happen. That was sort of ok since zopfli was just an enhancement over gzip, and lzma is used by nobody these days because of brotli taking off. And I don't think we have a rule to actually send any lzma files anyway...
Now about my issue: the
http-compression
hint asked for gzip and got that encoding (not zopfli), but it also could have asked for brotli and I was lead to understand that this should have been the case here:https://webhint.io/scanner/ad6908fd-a4e2-4c70-99f0-2ec2ca0c9e7b
To be clear, at the time of the report above, the gzip compression was indeed gzip when it could have been zopfli. That's now fixed on our end. That's not the current issue, it's about gzip-compatible VS brotli.
Examples:
Here are the contents on disk (size in bytes, filename):
(Yes the "last-modified" dates are not optimal, it's just rsync having lazy rules)
The text was updated successfully, but these errors were encountered: