Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab releases #824

Open
xaocon opened this issue Mar 19, 2024 · 4 comments
Open

GitLab releases #824

xaocon opened this issue Mar 19, 2024 · 4 comments

Comments

@xaocon
Copy link

xaocon commented Mar 19, 2024

I was wanting to add the glab client but it's hosted on gitlab.com and I see there isn't a release lib for it. I see in #4 that it was a consideration at some point but it was closed. Are you interested in this at all? I got started on adding it but ran into a bug with @root/request so before I go too much farther I wanted to make sure that you'd even be up for accepting it.

If you are up for adding GitLab, how do you feel about just using fetch instead of request? In case it matters, the issue with request is that it doesn't append or merge prior info on redirect so relative redirects cause Error: unknown protocol: 'null'.

@coolaj86
Copy link
Member

I'm in a good place for the next 2-3 weeks to focus on Webi, and I'm very open both:

  • add GitLab support
  • use native fetch

@root/request was a holdover between the time that request became so bloated and dependency-laden that it became a supply-chain vulnerability, and fetch still didn't have full browser+node support.

Do you have time to work on this in the next 2-3 weeks?

@coolaj86
Copy link
Member

@xaocon Are you still interested in GitLab support for Webi?

@xaocon
Copy link
Author

xaocon commented Aug 23, 2024

@xaocon Are you still interested in GitLab support for Webi?

Sure, I'll probably carve some time out for it this weekend.

@coolaj86
Copy link
Member

@xaocon bump.

If you get that in this weekend, it's a great time for me to review the PR and get it in.

Also, I just updated _common/githubish.js and _common/githubish-source.js, which would be a good start to copy/paste from. I bet throwing those into GPT with a "convert these from GitHub to GitLab" would actually work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants