-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul availability testing and add expected input languages #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, we replace it with createOptionsAvailable() and params()
berlintay
approved these changes
Dec 13, 2024
domenic
added a commit
to webmachinelearning/writing-assistance-apis
that referenced
this pull request
Jan 17, 2025
* Add options for `expectedInputLanguages`, `expectedContextLanguages`, and `outputLanguage`. The former two are used for downloading additional material and early errors if the web developer's required input/context languages cannot be supported by the browser. The latter gives clarity about what to do given mixed-language inputs. * Remove the `capabilities()` method and the accompanying `AI*Capabilities` classes. The reasoning is as follows: Those classes had three APIs: `available`, `createOptionsAvailable()`, and `languageAvailable()`. `languageAvailable()` wasn't clear if it was talking about input, context, or output languages. Now that we have explicit options for those three, we could fold language availability testing into `createOptionsAvailable()`. But then, we can note that the `available` property is kind of useless, as just knowing that some possible combination of options/languages is supported is not helpful for any known use case. So, the only real functionality we care about is testing whether a given set of options to `create()` is supported. This was previously done via `(await ai.apiName.capabilities()).createOptionsAvailable()`. We instead expose it via `await ai.apiName.availability()`. This name is a bit clearer, and this design also avoids the complexity where we have to retrieve all the availability information for every combination of options during the call to `capabilities()`, for later sync access. Now we can just retrieve the relevant information during the call to `availability()`. This was previously discussed in webmachinelearning/prompt-api#29; see especially webmachinelearning/prompt-api#29 (comment). Closes #16. See also webmachinelearning/prompt-api#69 and webmachinelearning/translation-api#31.
domenic
added a commit
to webmachinelearning/translation-api
that referenced
this pull request
Jan 17, 2025
…tector Add an `expectedInputLanguages` option to language detector creation API. This allows the browser to download relevant material if necessary, or fail-fast if a language the web developer needs to support is not available. Then, remove the `capabilities()` methods and the accompanying `AI*Capabilities` classes. * For translator, the only useful capabilities API was `(await ai.translator.capabilities()).languagePairAvailable()`. We simplify this to `await ai.translator.availability()`. This design also avoids the complexity where we have to retrieve all the availability information for every combination of options during the call to `capabilities()`, for later sync access. Now we can just retrieve the relevant information during the call to `availability()`. Also, by unifying on using the same options for `create()` and `availability()`, we fix #24. * For language detector, the capabilities supplied both `(await ai.languageDetector.capabilities()).available` and `(await ai.languageDetector.capabilities()).languageAvailable()`. We simplify this into `await ai.languageDetector.availability()`, which can either take no arguments (emulating `available`) or take the same `{ expectedInputLanguages }` argument as `create()` (emulating `languageAvailable()`). See also webmachinelearning/writing-assistance-apis#22 and webmachinelearning/prompt-api#69.
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Feb 5, 2025
Implement the new APIs as described to webmachinelearning/prompt-api#69, split the existing `capabilities()` API to `availability()` and `params()`. The old APIs are still kept on purpose and they will be removed soon. The WPTs are updated accordingly. Bug: 390459309 Change-Id: I70054f3debbef1a4f1be426d5a1caf4f1bc6354c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6181653 Reviewed-by: Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Commit-Queue: Mingyu Lei <leimy@chromium.org> Cr-Commit-Position: refs/heads/main@{#1416025}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
ai.languageModel.capabilities()
method and its accompanyingAILanguageModelCapabilities
class. Instead, replace it with:ai.languageModel.availability(options)
, which takes the same options asai.languageModel.create()
, and returns the corresponding availability.ai.languageModel.params()
, which returns the default and max params (currently top-K and temperature).Additionally, add the
expectedInputLanguages
option tocreate()
andavailability()
. The addition of this option tocreate()
allows the web developer to signal the expected input languages ahead of time, allowing the downloading of additional material, or fast-failing if the additional material cannot be supported. The addition of this option toavailability()
replaces the(await ai.languageModel.capabilities()).languageAvailable()
method.Closes #29; see especially #29 (comment).
See also webmachinelearning/writing-assistance-apis#22 and webmachinelearning/translation-api#31.