Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define equality for non-trivial data types #792

Open
a-sully opened this issue Nov 22, 2024 · 1 comment
Open

Define equality for non-trivial data types #792

a-sully opened this issue Nov 22, 2024 · 1 comment

Comments

@a-sully
Copy link
Contributor

a-sully commented Nov 22, 2024

From https://github.com/webmachinelearning/webnn/pull/787/files#r1854479095

We should define [=MLOperandDescriptor/equals=] method to be used when comparing MLOperandDescriptors

@inexorabletash
Copy link
Member

And more context (given in the link above) - https://garykac.github.io/procspec/#conditions has good guidance; Infra doesn't define equality for maps, so we should either define it for descriptors, or maps in general (and upstream that).

The spec also does list equality all over the place, e.g. "If its shape is not equal to « outputChannels », then..." and Infra doesn't define equality for lists either. List equality is probably more obvious than map equality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants