Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSF Page does not allow you to edit the configs #199

Closed
Cronus89 opened this issue Jul 4, 2015 · 10 comments
Closed

CSF Page does not allow you to edit the configs #199

Cronus89 opened this issue Jul 4, 2015 · 10 comments

Comments

@Cronus89
Copy link

Cronus89 commented Jul 4, 2015

When I go to edit a file with the webmin csf module, such as "Firewall Allow IP's" which is /etc/csf/csf.allow

It will not let me change any text, type new characters etc. Sometimes it will but very rarely.

@iliajie
Copy link
Collaborator

iliajie commented Jul 4, 2015

I remember fixing it but I will take a look again. To make it work so far, as work around, just simply click with the mouse outside of the editor box and then again inside of it. It should work.

I had hard times understanding why it happens.

@iliajie
Copy link
Collaborator

iliajie commented Jul 9, 2015

Did it help?

@Cronus89
Copy link
Author

Cronus89 commented Jul 9, 2015

I haven't had to edit lately, and I just tested and its letting me edit it for now.

@iliajie
Copy link
Collaborator

iliajie commented Jul 9, 2015

Alright, good to hear. Issue is closed for now.

@iliajie iliajie closed this as completed Jul 9, 2015
@Cronus89
Copy link
Author

I don't know why you closed this honestly. It's not "fixed" it just wasnt breaking at the time I replied. Its still broken,and I can't edit again. The workaround does not work.

@iliajie iliajie reopened this Jul 18, 2015
@iliajie
Copy link
Collaborator

iliajie commented Jul 18, 2015

Clicking outside worked for me. I knew about this issue since the very beginning. I have no idea why this is happening, really.

..but will do my best to figure out and fix it. I might remove code mirror on CSF completely, in the future release to solve this.

@Cronus89
Copy link
Author

After clicking willy nilly all over the place, the workaround works..somewhat. You can't select text though. hopefully that helps a tiny bit.

I honestly was gonna reccomend removing it from csf all together. I kinda like their UI anyhow.

Appreciate all the fine work, this theme really is the best, and brought a new light to webmin.

@iliajie
Copy link
Collaborator

iliajie commented Jul 18, 2015

Thanks, pal. I will try to make it work.

@iliajie
Copy link
Collaborator

iliajie commented Jul 18, 2015

There are issues familiar to our problem. Seems the origin is still unknown:

codemirror/codemirror5#3261
codemirror/codemirror5#2219

@iliajie
Copy link
Collaborator

iliajie commented Jul 18, 2015

This will be fixed in version 14 in couple of days. I will remove CodeMirror from it but make some heights adjustments to make it fit properly. It's alright without it. It will work just fine.

@iliajie iliajie closed this as completed Jul 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants