cannot delete firewall rule in firewall module

[gnadelwartz]

I'm not able to delete or move selected firewall rules in firewall module. If I klick on delete or move it calls save_policy.cgi but the rules are not delete/moved and diplayed again. I'm using direct mode.

create edit is working, also delete from edit form.
can pls someone test and confirm it?

I had a look at save_policy (deslsel/movesel) and save_table() in firewall_lib but can't locate the issue.

[iliajie]

Did it happen before?

[gnadelwartz]

did not test it for some time, but when I go back to 1.860 its the same. So please can someone test if its my setup (proxy/updates from repo) or a general error.

Test should really simple: add a new rule, select it in the table and try to delete it.

[iliajie]

I also couldn't delete it on my Debian Linux.

Looks like a bug. I wish you told me that before the release. It's nothing but I'll only be able to look at it in the morning.

[gnadelwartz]

sorry, noticed it a few minutes ago as my server sudently reboots an I wanted to delete some duplicate rules from fail2ban.

[iliajie]

You mean Linux Firewall module or Fail2Ban?

[gnadelwartz]

linux firewall

[iliajie]

It will need a fix. This module has issues with HTML output. It's not directly theme issue.

[gnadelwartz]

I know, thats why I post it ro webmin :-)

[jcameron]

Ilia, what's the HTML issue exactly?

[iliajie]

Jamie, I still see the issue but it's not what I saw last night.

Anyway, right now, after further investigation, I have noticed that Gray Theme passes input[name="table"] and input[name="chain"] values to save_policy.cgi.

---

Again, right before posting this comment, I remembered that I had issue request in this regard, that addressed issue with not working Showing IP table and Add a new chain named button at the very top of the page.

My patch had broken table and chain inputs exactly as it was applied to all of them, instead to only first ones.

Here is what I mean by omitted/empty forms (Gray Theme, same as Authentic Theme):

Look, you see the form is soaring somewhere else, all empty? Well, it's not going to work with AJAX calls properly.

I made a fix to my fix (just now) to make it look/work properly, so the form will contain needed elements unambiguously.

To address this issue, I will fix my code for now, because it still needs a fix anyway. In the future, we'd better fix server part or/and not build modules this way.

I will go with 19.05 just in a bit for upcoming Webmin release. I will also try to beautify buttons above for switching IPv4/IPv6 protocols.

[iliajie]

It's been fixed. Jamie, you can just git pull to include these changes for upcoming Webmin release.

[gnadelwartz]

as already stated in private chat this fixed the issue at least for me. thanks for investigating and sorry for the last minute report.

[jcameron]

Fix in Webmin is here : f5a4dcb

[iliajie]

Alright, Jamie. I have pushed force update for 19.04. Please pull the latest changes.

@gnadelwartz Could you please pull the latest changes for the theme and Jamies and try again to be fully sure?

[gnadelwartz]

its working for me...

[gnadelwartz]

ipv6 is also working