Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8 syntax error #742

Closed
brandonfarber opened this issue Nov 30, 2020 · 1 comment · Fixed by #743
Closed

PHP 8 syntax error #742

brandonfarber opened this issue Nov 30, 2020 · 1 comment · Fixed by #743
Labels
bug

Comments

@brandonfarber
Copy link
Contributor

https://php.watch/versions/8.0/deprecate-required-param-after-optional

Required parameters declared after optional parameters now throw a deprecation notice.

https://github.com/webonyx/graphql-php/blob/master/src/Error/FormattedError.php#L280

You can just get rid of the = null in the argument list. callable is already nullable via the ? mark
@spawnia
Copy link
Collaborator

spawnia commented Nov 30, 2020

Can you create a PR?

@spawnia spawnia added the bug label Nov 30, 2020
@brandonfarber brandonfarber mentioned this issue Dec 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix PHP 8 deprecation: Required parameters after optional parameter brandonfarber/graphql-php
2 participants
@brandonfarber @spawnia