Skip to content
This repository has been archived by the owner on Mar 16, 2020. It is now read-only.

Consider moving this into webpack/webpack? #1

Closed
TheLarkInn opened this issue Aug 29, 2016 · 8 comments
Closed

Consider moving this into webpack/webpack? #1

TheLarkInn opened this issue Aug 29, 2016 · 8 comments

Comments

@TheLarkInn
Copy link

Hey!!! My name is Sean, and I'm one of the core maintainers for webpack. By the way, nice job on creating something so quickly after the release of babili.

Since webpack already owns UglifyJSPlugin, I'd love to see this also moved into our organization, whether it be added as core code, or a repo underneath the org.

The webpack team wants to have optimization stuff as much "Out of the box" as possible for user configuration.

  1. Would you be willing to propose a RFC/Proposal/PullRequest for this on our repo? This plugin would probably be something that lives under webpack/lib/optimize.
  2. If the movement on number 1 is slow, could the webpack org consume the repo, for separate development.

Would you be open to either of these ideas? This will give us a lot more hands on in helping maintain and configuring the plugin for speed and performance, etc.

Let me know what you think. And again thanks for your work.

@boopathi
Copy link
Member

boopathi commented Aug 29, 2016

Sure. I don't have any concerns where the code lies. I can send a PR.

There are a few concerns that I think should be considered -

  1. name: Name change to babel-minify babel/minify#124
  2. [ EDIT - Optimizing webpack build with babel & babili #8 ]. whether this plugin is the best way to add minification to build pipeline - babili babel/website#898 (comment) . Either way this plugin will be useful. Also, any help should be really useful.

@TheLarkInn
Copy link
Author

Awesome I'd like to discuss with the core team first their thoughts. I'll followup with you in about a week. Again thank you for the work and flexibility.

@boopathi boopathi mentioned this issue Aug 29, 2016
9 tasks
@jorgebucaran
Copy link

👋 Hi folks. Whatever happened to moving this plugin to webpack/webpack?

Cheers.

@TheLarkInn
Copy link
Author

We could think about moving this into webpack-contrib

@bebraw
Copy link

bebraw commented Mar 3, 2017

Any news on the transfer? I understand if you want to retain it under your account. No probs with that.

@boopathi
Copy link
Member

boopathi commented Mar 3, 2017

Hey. Nothing like that. We can transfer it now.

How do we do it ? Do I give you access to the repo ? or do you give me access to the org for the transfer ?

@bebraw
Copy link

bebraw commented Mar 3, 2017

@boopathi I invited you to the org so you should be able to rename the repo to complete the transfer. Thanks a lot. 👍

@boopathi
Copy link
Member

boopathi commented Mar 3, 2017

👍

@boopathi boopathi closed this as completed Mar 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants