Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

get module name from component.json #5

Open
sokra opened this issue Jul 1, 2014 · 5 comments
Open

get module name from component.json #5

sokra opened this issue Jul 1, 2014 · 5 comments

Comments

@sokra
Copy link
Member

sokra commented Jul 1, 2014

see webpack/webpack#337

Instead of infering the module name from the path name, it should be read from the component.json.

  1. Read all component.jsons for all dependencies.
  2. Use the component which component.jsons name field matches the request.

This is a bigger refactoring...

@lmartins
Copy link

lmartins commented Jul 2, 2014

Thank you @sokra
Now that I know how to temporarily fix it it isn't so urgent, but nice to have in the future. Im certain you have more urgent tasks at hands.

@st32lthx
Copy link

@lmartins, I was wondering what fix you used. I am having difficulty loading components with webpack. I think the plugin assumes the component.json file is a direct child of the component folder. While components folder structure seems to be more like:

component-name
   |_ v.x.y.z
        |_ component.json
        |_ index.js

Even though I pass an array of paths for the lookupPaths, the plugin can't resolve the module.

Thanks!

@lmartins
Copy link

@aminmeyghani although I will possibly use again in the future, I am now using a different solution and to be honest can't quite recall what I did then.

@st32lthx
Copy link

Thanks @lmartins ! Just wondering, do you use another plugin to work with component and webpack ?

@lmartins
Copy link

No, for the time being im using JSPM to build my JS projects.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants