Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow async transforms #111

Merged

Conversation

Perlmint
Copy link
Contributor

Currently implemented a way of the transform is synchronous transform only available. Fixing little makes asynchronous transform available.

@matthewmueller
Copy link

+1, this is (unfortunately) needed for things like cssnano

@kunshao-msft
Copy link

+1 what is the status of this PR?

@michael-ciniawsky
Copy link
Member

michael-ciniawsky commented Oct 5, 2017

@Perlmint Could you please rebase against current master to make reviewing this easier ?

@Perlmint Perlmint force-pushed the feature/transform-promise branch from 04cc411 to ec32c8a Compare October 6, 2017 00:47
@jsf-clabot
Copy link

jsf-clabot commented Oct 6, 2017

CLA assistant check
All committers have signed the CLA.

@Perlmint
Copy link
Contributor Author

Perlmint commented Oct 6, 2017

@michael-ciniawsky I just pushed rebased commits!

Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Perlmint Thx

@michael-ciniawsky
Copy link
Member

@Perlmint Please sign the CLA by closing and reopening the PR to trigger the CLA Bot again

@michael-ciniawsky michael-ciniawsky added this to the 4.1.2 milestone Oct 6, 2017
@Perlmint Perlmint closed this Oct 6, 2017
@Perlmint Perlmint reopened this Oct 6, 2017
@joshwiens
Copy link
Member

Bit of housekeeping, this is more an improvement than a bug fix. I'd prefer to increment the minor version here as this is additional functionality. @michael-ciniawsky @evilebottnawi

@alexander-akait
Copy link
Member

@d3viant0ne yes, you are right

@michael-ciniawsky michael-ciniawsky modified the milestones: 4.1.2, 4.2.0 Oct 6, 2017
@michael-ciniawsky michael-ciniawsky changed the title fix: allow async transforms feat: allow async transforms Oct 6, 2017
@michael-ciniawsky
Copy link
Member

@Perlmint Could you please rebase one more time, bc of #155. Sry for the inconvenience 😅

@Perlmint Perlmint force-pushed the feature/transform-promise branch from ec32c8a to f180a7d Compare October 19, 2017 12:01
@Perlmint
Copy link
Contributor Author

@michael-ciniawsky rebased!

@michael-ciniawsky michael-ciniawsky merged commit 8794e5f into webpack-contrib:master Oct 19, 2017
@SeyfAllahCheref
Copy link

@michael-ciniawsky When the 4.2.0 release is planned please?

@alexander-akait
Copy link
Member

@SeyfAllahCheref asap

@michael-ciniawsky michael-ciniawsky removed this from the 4.3.0 milestone Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants