feat: add context option (options.context)
#149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-ciniawsky
changed the title
context option (options.context)
michael-ciniawsky
approved these changes
Oct 5, 2017
| @@ -46,6 +47,15 @@ function CopyWebpackPlugin(patterns = [], options = {}) { | |||
| let contextDependencies; | |||
| const written = {}; | |||
|
|
|||
| let context; | |||
There was a problem hiding this comment.
\n between the variable declaration and the if block please :)
There was a problem hiding this comment.
Should I place it up with the other lets and consts as well?
michael-ciniawsky
requested review from
alexander-akait
and removed request for
boopathi
michael-ciniawsky
changed the title
context option (options.context)context option (options.context)
|
@cletusw Please rebase when time :) |
Overrides webpack context, overridden by pattern context Fixes webpack-contrib#148
|
@michael-ciniawsky Rebased. |
alexander-akait
approved these changes
Oct 19, 2017
michael-ciniawsky
added
status: Approved
and removed
priority: 5 (nice to have)
pr_action: Review
status: Pending
labels
|
@michael-ciniawsky Awesome! Let me know when these patches get a version bump, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overrides webpack context, overridden by pattern context
Fixes #148