feat: accept semver compatible postcss AST #1049
Conversation
package.json
Outdated
| @@ -54,7 +54,8 @@ | |||
| "postcss-modules-scope": "^2.1.1", | |||
| "postcss-modules-values": "^3.0.0", | |||
| "postcss-value-parser": "^4.0.2", | |||
| "schema-utils": "^2.6.0" | |||
| "schema-utils": "^2.6.0", | |||
| "semver": "^7.1.2" | |||
There was a problem hiding this comment.
https://github.com/npm/node-semver/blob/master/package.json#L36
I think we need to use lower version
There was a problem hiding this comment.
I can try and find one. Ya'll know that node 8 is End of Life right?
There was a problem hiding this comment.
We still support node@8 https://github.com/webpack-contrib/css-loader/blob/master/package.json#L16, In the near future there will be a release that will throw out support node@8, but right now it is breaking change, so we should avoid it
There was a problem hiding this comment.
yup, just wanted to make sure ya'll knew.
Codecov Report
@@ Coverage Diff @@
## master #1049 +/- ##
==========================================
+ Coverage 98.14% 98.15% +0.01%
==========================================
Files 10 10
Lines 484 487 +3
Branches 150 152 +2
==========================================
+ Hits 475 478 +3
Misses 8 8
Partials 1 1
Continue to review full report at Codecov.
|
This PR contains a:
Motivation / Use-Case
This is a nice optimization css-laoder does, but seems hard to hit, given how little control the end user has to ensure they only have one particular postcss.
Breaking Changes
Additional Info