-
-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support asyncronous functions in config.url
and config.import
.
#1277
Support asyncronous functions in config.url
and config.import
.
#1277
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1277 +/- ##
=======================================
Coverage 99.46% 99.47%
=======================================
Files 11 11
Lines 753 762 +9
Branches 258 261 +3
=======================================
+ Hits 749 758 +9
Misses 4 4
Continue to review full report at Codecov.
|
Ah, I thought I had run the validations beforehand but must've missed the lint (it can sometimes be tricky to know what automated checks will be run). Little embarrassing to need two commits for such a small change so I'd expect they should be smushed or combined with --force. Looks like you have the no-await-in-loop rule enabled. Would it be appropriate to add a commit that ignores that with Lint errors for reference:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
await
inside for of
, it is bad for performance, we need refactor code and use Promise.all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I will look at this in near future
Sounds good, hope it all adheres now (fail the first commit's message format). As a side note, I struggled with CRLF vs LF differences in the test, I'm assuming because the test snapshots are formatted with Linux/Mac line endings. WSL didn't seem to help in this case either. I struggled with that for a while before deciding to just ignore test failures complaining about |
This PR contains a:
Motivation / Use-Case
Fixes #1236.
Breaking Changes
None
Additional Info
My apologies for the issue lingering open. Apparently I must've cleared all my notifications and missed your response. I don't believe anything like the schema needs updating (async functions are instance of Function) so the change is pretty small.